Closed JoviDeCroock closed 4 months ago
Latest commit: 83bcaeb7154802624c21e4e51a2a0f3f8e27eb0a
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 83bcaeb7154802624c21e4e51a2a0f3f8e27eb0a |
Latest deploy log | https://app.netlify.com/sites/preact-signals-demo/deploys/6687981c039d200008fea472 |
Deploy Preview | https://deploy-preview-582--preact-signals-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Size Change: +491 B (+0.61%)
Total Size: 81 kB
Filename | Size | Change |
---|---|---|
packages/react-transform/dist/signals-*********.js |
4.91 kB | +165 B (+3.48%) |
packages/react-transform/dist/signals-transform.mjs |
4.17 kB | +161 B (+4.02%) |
packages/react-transform/dist/signals-transform.umd.js |
5.03 kB | +165 B (+3.39%) |
Apparently I missed the Suspense tests, I would probably also need to look at higher order components before feeling confident as we might need an early return case for hoc's.
Should be covered in https://github.com/preactjs/signals/pull/582/commits/a8a4f8685a8c0e43fd39d1d15a1c6dc5b354acd2 all tests are passing for me, let's see about CI
This was a bit more complex than initially anticipated due to how we have chosen to transform, I wanted to make as little change as possible so here goes...
memberExpression
that zooms out towards the component definitionuseEffect
/... we bailFixes https://github.com/preactjs/signals/issues/552 Supersedes https://github.com/preactjs/signals/pull/553