Closed JoviDeCroock closed 3 years ago
Latest commit: 7e28300de70f048337c913c382863f53b228cde3
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Size Change: +126 B (+2%)
Total Size: 6.32 kB
Filename | Size | Change |
---|---|---|
packages/preact-iso/.dist/index.********.js |
1.72 kB | +52 B (+3%) |
packages/preact-iso/.dist/prerender.********.js |
348 B | -2 B (-1%) |
packages/preact-iso/router.js |
2.54 kB | +76 B (+3%) |
If we land this, I feel like we should also land a callback that fires after every successful route (sync or async), like onDidRoute
. I often want to register a callback to do stuff like change title/reset scroll/etc
Fixes https://github.com/preactjs/wmr/issues/836
Ref solution: https://github.com/preactjs/wmr/pull/864/commits/d6c87e340538c341e7826b7b043dec03ddc306fd (ties into the effect on every render) State solution: https://github.com/preactjs/wmr/pull/864/commits/960364758bd818d8c00a482ef4c346c7adc05554 (avoids using effect on every render)