search

preactjs / wmr

👩‍🚀 The tiny all-in-one development tool for modern web apps.
https://wmr.dev/
MIT License
4.92k stars 109 forks source link

Fix: TS config file using DefineConfig in a non-type="module" project #915

Closed rschristian closed 2 years ago

rschristian commented 2 years ago

Closes #914

AFAIK that "exports" shouldn't cause an issue for anyone?

We also don't have .cjs in our allowlist of config file extensions, but could add it later I suppose. Not needed now, and I don't think anyone's asked for it.

https://github.com/preactjs/wmr/blob/caf7ff840363351b0f52eabf1eff91c3e9888c04/packages/wmr/src/lib/normalize-options.js#L96

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: b72c4cdd336e011a820926287e25d420660bd878

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---- | ----- | | wmr | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

developit commented 2 years ago

fairly certain the compressed-size-action segfault is random.

rschristian commented 2 years ago

It's pretty consistent on Node 16+. Not all the time, but 75% IME.

I think I hit it once or twice on 14, but could be misremembering. Really odd though, it's the prerender that causes it.

rschristian commented 2 years ago

Actually, this is dumb, we should just transpile the TS configs to ESM. Gonna fix that real quick.