search

preactjs / wmr

👩‍🚀 The tiny all-in-one development tool for modern web apps.
https://wmr.dev/
MIT License
4.92k stars 109 forks source link

fix: As of Node 16, `fs.rmdir()` throws if path does not exist #938

Closed rschristian closed 2 years ago

rschristian commented 2 years ago

https://nodejs.org/api/fs.html#fspromisesrmdirpath-options

Breaks our CI now that we're testing Node v18. Simple catch & swallow should be fine in all likelihood.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 2b842d024a71d5ced92cbb3e371b7cf89b5d0d55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/preactjs/wmr/new/fix/test-suite-node-16?filename=.changeset/popular-spoons-nail.md&value=---%0A%22wmr%22%3A%20patch%0A---%0A%0Afix%3A%20As%20of%20Node%2016%2C%20%60fs.rmdir()%60%20throws%20if%20path%20does%20not%20exist%0A)

rschristian commented 2 years ago

The prerendering segfault is back, which is fun (he said very sarcastically).