preactjs / wmr

👩‍🚀 The tiny all-in-one development tool for modern web apps.
https://wmr.dev/
MIT License
4.92k stars 109 forks source link

create-wmr: install eslint and eslint-config-preact as dev dependencies #940

Closed joebeachjoebeach closed 1 year ago

joebeachjoebeach commented 1 year ago

I noticed while using create-wmr that when passing --eslint, eslint and eslint-config-preact ended up in "dependencies" instead of "devDependencies" in my package.json.

Notes

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: f9469fdb7000e84546fd57edf7c43a42c88d1de5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------- | ----- | | create-wmr | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

rschristian commented 1 year ago

Running yarn prepare in the create-wmr package directory hangs and uses up a whole lot of my CPU.

Odd. Mind sharing your environment? Don't know what would cause that, and it's seemingly find for me.

But thanks for putting this together! Really appreciate it.

joebeachjoebeach commented 1 year ago

@rschristian thanks for the quick turnaround!

Mind sharing your environment?

macOS 11.6, and it has the same behavior with node 16.18.0 and 18.11.0. not sure what's causing it, but I figure it's a "me" thing and I'll dig into it