search

preactjs / wmr

👩‍🚀 The tiny all-in-one development tool for modern web apps.
https://wmr.dev/
MIT License
4.92k stars 109 forks source link

add http-compression #951

Closed Kikobeats closed 1 year ago

Kikobeats commented 1 year ago

Hello,

I backported @polka/compression into a standalone package, so you don't need to copy/paste anymore 🙂

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 6ee9d26b53b2dc542a7fb97062d93d5803343f47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rschristian commented 1 year ago

Fully agree with what Patak wrote over on Vite: https://github.com/vitejs/vite/pull/11815#issuecomment-1514375142

Adding a dependency is always something to be careful about, and the selling point for this one is... moving a little bit of code outside the project? I don't think it's particularly compelling.

Thanks for writing a PR though.