search

preactjs / wmr

👩‍🚀 The tiny all-in-one development tool for modern web apps.
https://wmr.dev/
MIT License
4.92k stars 109 forks source link

Move wmr.cjs to wmr.js (esm) #963

Open renhiyama opened 11 months ago

renhiyama commented 11 months ago

If the cli binary is converted into esm format, it would make it easier for URL imports, making the world a better place to live in. Well maybe that was an exaggeration, but atleast it would make https://esm.sh work.

Currently neither https://cdn.jsdelivr.net/npm/wmr/wmr.cjs/+esm works nor https://esm.sh/wmr/wmr.cjs works.

Considering nodejs now supports esm, it would be better to make the code ready for the future 😁

developit commented 11 months ago

What is the use case for loading this via a CDN? It's a 2mb CLI.

renhiyama commented 11 months ago

What is the use case for loading this via a CDN? It's a 2mb CLI.

I could use it over reejs URL imports, basically URL imports for nodejs & bun (and works alongside with deno ofc).

Also is there any reason why you're still bundling cjs and not esm though? Pretty sure nodejs can do much better with esm.

rschristian commented 11 months ago

I could use it over reejs URL imports, basically URL imports for nodejs & bun (and works alongside with deno ofc).

Why would you be importing it at all though? As mentioned, it's a CLI, generally not something you'd ever want to import.

Also is there any reason why you're still bundling cjs and not esm though?

This repo hasn't seen any development in a couple years, if you hadn't noticed. Node 12 was the original release target and it did not have great ESM support (though module format is mostly irrelevant for a CLI).

Pretty sure nodejs can do much better with esm.

I'm not quite sure what you think would be better?