search

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.31k stars 2.07k forks source link

Sharethrough bid adapter generates invalid sync URLs #10478

Closed spormeon closed 1 year ago

spormeon commented 1 year ago

Type of issue

consent being added to domain and throwing error

Description

Steps to reproduce

in V8.11.0 there is no error , test page: https://cdn.adysis.com/VideoDemo/DemoSite/pages/BBH.html

in V8.13.0 a error is being thrown and it looks like consent is being added onto the domain ( no idea where this is coming from): DevTools_-_cdn_adysis_com_VideoDemo_DemoSite_pages_BBH8_13_0_html_and_Lee_Westwood_v_Ian_Poulter_v_Jimmy_Bullard__It’s_The_Nuts___-_YouTube_🔊

test page: https://cdn.adysis.com/VideoDemo/DemoSite/pages/BBH8.13.0.html

Expected results

no error to be throw and no domain url with consent on it

Actual results

error being thrown with domain url being created with what looks like consent etc on it

Platform details

chrome, mac, V8.11.0 V's V8.13.0

Other information

dgirardi commented 1 year ago

I believe this was introduced by #10388; sometimes the sharethrough bid adapter will return an invalid user sync URL (paging @jefftmahoney):

image

I don't think this affects anything beside sharethrough's user syncs, so from a publisher's point of view it should be close to inconsequential.

deivydas commented 1 year ago

Hey @spormeon, This issue should be fixed now. We have noticed that there were empty strings delivered in some cases as user sync urls. We have introduced measures in our backend to not have this situation.

lcorrigall commented 1 year ago

Can this be closed?

spormeon commented 1 year ago

@lcorrigall fine by me, if @deivydas is sure its sorted out now, backend logs disapeared?