prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.28k stars 2.05k forks source link

Q: Why browsingTopics: true by default on all outgoing bidder requests? #11148

Open orazumov-zeta opened 7 months ago

orazumov-zeta commented 7 months ago

Type of issue

Question

Description

Why browsingTopics: true by default on outgoing bidder requests? (sources) Related PR: Core: enable Sec-Browsing-Topics header on outgoing bidder requests https://github.com/prebid/Prebid.js/pull/10340

image

Not all bidders support this. As a result, in Chrome console, I see numerous errors of the type 'Attestation check for Topics on URL failed.' There is an option 'topicsHeader' to control this. Perhaps it would be better to have browsingTopics enabled not by default, but only when this option is explicitly specified?

Steps to reproduce

Open the Chrome browser console on any page where Prebid.js is running with configured bidders that do not support browsingTopics (for example, appnexus, mediafuse, sovrn, minutemedia, etc.). You will see errors Attestation check for Topics on URL failed.

image

Test page

Here you can see such error: https://www.bmwblog.com/2024/02/26/how-a-bmw-7-series-turned-from-city-cruiser-to-off-road-adventurer/

Expected results

Actual results

Platform details

Prebid.js 8.35 Chrome 121.0.6167.184 (Official Build) (arm64)

Other information

Core: enable Sec-Browsing-Topics header on outgoing bidder requests

dgirardi commented 7 months ago

Are those error messages a problem? As far as I know they are inconsequential, so it seems reasonable to try to include topics by default, since for the exchanges that can accept them they are valuable.

patmmccann commented 7 months ago

We were hoping the error messages would encourage adoption. The Chrome team actually noted this in their repo https://github.com/patcg-individual-drafts/topics/pull/289

My inclination is bidders generating warnings should handle individually.

dgirardi commented 7 months ago

We can set suppressTopicsEnrollmentWarning: true unless debug is true.

msperone commented 2 weeks ago

A fix for this error would be greatly appreciated! I understand the perspective of throwing errors to encourage adoption of the feature. But this is a lot of noise in the javascript console and has caused my team to miss some legitimate errors.

I like the idea to suppress the error unless debugging is turned on.