search

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
http://prebid.org
Apache License 2.0
1.25k stars 2k forks source link

cee Id System : initial ID module release #11510

Closed decemberWP closed 1 week ago

decemberWP commented 2 weeks ago

Type of change

Description of change

Name change from pirIdSystem to ceeIdSystem

Other information

decemberWP commented 2 weeks ago

Github shows these changes a bit weird, because on branch grupawp:ceeidsystem I've deleted pirIdSystem.js, pirIdSystem.md and pirIdSystem_spec.js however it doesn't show it's deleted. Should I create another PR to just delete these files?

ChrisHuie commented 2 weeks ago

Github shows these changes a bit weird, because on branch grupawp:ceeidsystem I've deleted pirIdSystem.js, pirIdSystem.md and pirIdSystem_spec.js however it doesn't show it's deleted. Should I create another PR to just delete these files?

Yes. However, the delete will need to happen in a major release. Right now we have a prebid.js 9.0 branch for our upcoming major release with breaking changes. If you can submit your delete pr to that branch it would be appreciated.

decemberWP commented 1 week ago

@ChrisHuie Thanks for info. PirIdSystem delete PR here: https://github.com/prebid/Prebid.js/pull/11518