search

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.28k stars 2.06k forks source link

Media.net Analytics and Bid Adapter: import common functions #11936

Open patmmccann opened 3 months ago

patmmccann commented 3 months ago 
  _getAttributeFromSelector and other adjacent functions should be imported by both adapters.

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Originally posted by @github-actions[bot] in https://github.com/prebid/Prebid.js/issues/11924#issuecomment-2208568377

patmmccann commented 3 months ago

cc @adish1997 @adish-r