Various Bid Modules: preventing custom aliases

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.

https://docs.prebid.org

Apache License 2.0

1.33k stars 2.09k forks source link

Various Bid Modules: preventing custom aliases #12135

Open andyblackwell opened 3 months ago

andyblackwell commented 3 months ago

Type of issue

similar to #12047, the bid validation in these bid adapters prevents custom aliasing

33acrossBidAdapter: https://github.com/prebid/Prebid.js/blob/8.52.0/modules/33acrossBidAdapter.js#L76
sharethroughBidAdapter: https://github.com/prebid/Prebid.js/blob/8.52.0/modules/sharethroughBidAdapter.js#L21C49-L21C78

Description

bidders don't need to validate the bidder name in isBidRequestValid(), prebid handles that already, and when they do, it prevents being able to use custom aliases, rejecting bids as invalid when a custom alias is used

Steps to reproduce

use a custom alias for the bidders

Expected results

bid requests sent in the auction

Actual results

bids rejected as invalid due to unnecessary bidder name validation

Platform details

all prebid versions that I can tell

Other information

similar issue to #12047

andyblackwell commented 3 months ago

grepped through all the adapters to find any others with a similar issue:

[x] - 33acrossBidAdapter
[ ] - adWMGBidAdapter
[ ] - adrinoBidAdapter
[ ] - advangelistsBidAdapter
[ ] - anyclipBidAdapter
[ ] - bucksenseBidAdapter
[ ] - c1xBidAdapter
[ ] - cadentApertureMXBidAdapter
[x] - connatixBidAdapter
[ ] - deltaprojectsBidAdapter
[ ] - jixieBidAdapter
[ ] - lkqdBidAdapter
[ ] - my6senseBidAdapter
[x] - nativoBidAdapter
[ ] - onomagicBidAdapter
[x] - saambaaBidAdapter
[ ] - setupadBidAdapter (this one has logic in onBidWon that'd prevent a custom alias from running that snippet)
[x] - sharethroughBidAdapter

patmmccann commented 3 months ago

@jefftmahoney fyi

patmmccann commented 3 months ago

@andyblackwell feel free to submit pr on anyone affecting you, I'll merge without consulting them

However 8.x is closed for additional releases

jefftmahoney commented 3 months ago

@andyblackwell @patmmccann - PR submitted to address this for Sharethrough's adapter (12136). Let me know if you have any questions or need anything further!

patmmccann commented 4 weeks ago

https://github.com/prebid/Prebid.js/blob/7214c8e742eda284e9c772b5c190ea7759b584ca/modules/nativoBidAdapter.js#L126 looks like a false positive given the conditional