search

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.33k stars 2.08k forks source link

Video - javascript error when Rubicon is the only bidder and it returns empty bid or error #1688

Closed ghost closed 7 years ago

ghost commented 7 years ago

Type of issue

Bug

Description

For video header bidding, when Rubicon is the only bidder configured and it returns an empty bid or error, we get a javascript error:

ERROR: Error executing bidsBackHandler" TypeError: Cannot read property 'adserverTargeting' of undefined

in pbjs.adServers.dfp.buildVideoUrl. Video doesn't play.

Steps to reproduce

Take the example JWPlayer code from here, replace appnexusAst bidder with rubicon and invalid IDs (to force an error), turn on debugging, view console.

Test page

jsfiddle

Expected results

No javascript error, video should still play. pbjs.adServers.dfp.buildVideoUrl should still return a valid URL.

Actual results

Javascript error, video doesn't play. pbjs.adServers.dfp.buildVideoUrl doesn't return.

Platform details

prebid v0.30.1. Tested on MacOS 10.12.6, Chrome 61.

ghost commented 7 years ago

screen shot 2017-10-13 at 09 07 07

mkendall07 commented 7 years ago

I think this issue is consistent across video bidders, so most likely not a rubicon adapter issue.