New OpenX adapter update ends up with no requests

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.

https://docs.prebid.org

Apache License 2.0

1.33k stars 2.09k forks source link

New OpenX adapter update ends up with no requests #1859

Closed UrTARGET closed 6 years ago

UrTARGET commented 6 years ago

Type of issue

bug?

Description

Updated to the latest version of prebid (v0.33 with openx adapter update), then number of requests going to openx server dropped massively. (150k requests dropped to less than 10 and decreasing daily)

Settings were left untouched, only updated the prebid version.

Platform details

prebid version 0.33, Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Other information

mkendall07 commented 6 years ago

@IHateCodesss can you take a look?

bwoolcott commented 6 years ago

@mkendall07 We've identified the issue here and developed a fix yesterday which is in QA today. We should be able to make a PR with the fix today. The issue was due to mediaType not defaulting to banner in v0.33.0 whereas in 1.0 it does. So, since mediaType wasn't explicitly declared as "banner", requests aren't being created.

UrTARGET commented 6 years ago

Do we need to download new prebid.js for the fix? and how long can we expect to see the fix to be effective?

mkendall07 commented 6 years ago

this is resolved in master now.