prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.33k stars 2.08k forks source link

Headerbid Expert, OpenX not showing on certain page #1926

Closed Takawari closed 6 years ago

Takawari commented 6 years ago

Type of issue

Possible small bug in Headerbid expert URL detection

Description

In Headerbid expert, on some pages OpenX is not shown when used for header bidding

Steps to reproduce

Go to the test page below and open Headerbid Expert

Test page

https://image.online-convert.com/convert-to-jpg

Expected results

See DFP and OpenX header bidding in Headerbid expert

Actual results

Only DFP showing in Headerbid expert

mkendall07 commented 6 years ago

@Takawari thanks for the report! It looks like we need to add the following pattern to HeaderBidding expert for openX: .openx.net/w/1.0/arj

You can submit a pull request here: https://github.com/prebid/headerbid-expert/blob/master/bidderPatterns.js#L8

Takawari commented 6 years ago

Pull request created: https://github.com/prebid/headerbid-expert/pull/2