prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.28k stars 2.05k forks source link

Appnexus prebid server unsupported bidders #2717

Closed sgagnierH closed 6 years ago

sgagnierH commented 6 years ago

Type of issue

Bidders in this list return "unsupported bidder" to an auction http://prebid.adnxs.com/pbs/v1/info/bidders

Description

Steps to reproduce

Just request a bid with those bidders with appnexus prebid server enabled.

Expected results

Bids!

Platform details

Prebid.js 1.13.0, AppNexus' prebid server

dbemiller commented 6 years ago

It looks like you're using prebid.adnxs.com/pbs/v1/auction as your endpoint. That's undocumented, and not been maintained in Prebid Server for a long time. Do you still see this issue if you use prebid.adnxs.com/pbs/v1/openrtb2/auction?

I only expect the /info/bidders endpoint to be in sync with /openrtb2/auction.

If so, could you post your s2sconfig and prebid.js ad units?

sgagnierH commented 6 years ago

You're right, I was not on /openrtb2/ link. Iswitched to it because ix was displaying errors actually. So back to it. Now, I can get openx bids.

if I include "ix" in the bidders, I get a 400 from prebid server. (Invalid request: request.imp[0].ext contains unknown bidder: ix. Did you forget an alias in request.ext.prebid.aliases?)

If I put indexEchange, it's simply ignored because the bids are sent to "ix", and according to docs from Index

audienceNetwork still sends a 400 on S2S but works great direct.

s2sConfig: { accountId: 'xx', bidders: ["appnexus","rubicon","openx","audienceNetwork"], defaultVendor: 'appnexus', enabled: true, timeout: 2000, adapter: 'prebidServer', endpoint: 'https://prebid.adnxs.com/pbs/v1/openrtb2/auction', syncEndpoint: 'https://prebid.adnxs.com/pbs/v1/cookie_sync', cookieSet: true, cookieSetUrl: 'https://acdn.adnxs.com/cookieset/cs.js', },

for AdUnits, tried many different. Works like a charm on AppNexus, Rubicon, and all adapters in direct mode, so can't see what can be wrong in S2S.

Tried to add an alias for indexExchange to ix without success.

mkendall07 commented 6 years ago

@sgagnierH Yeah looks like index renaming their bidder is going to cause us issues. I don't think changing the bidder name in PBS is a great idea since that would be a breaking change. @dbemiller would the best thing to do here to put a alias into PBS for indexExchange in the Prebid.js PBS adapter?

dbemiller commented 6 years ago

I think so, yeah. It's not really possible for Prebid Server to rename an adapter because that stuff lives directly in the DB :(.

It might be a shade cleaner to add indexExchange as an alias inside the ix adapter, rather than adding a special case to the PBS adapter. I believe the PBS adapter forwards all those aliases in the request.

bretg commented 6 years ago

Interesting one. Is the alias in the PBJS adapter, PBS adapter, or both?

chefbenjamin commented 6 years ago

Last time i spoke with Index ( 3 weeks ago) they were not yet actually supporting the deployment of them via prebid server at this time. They will in the future but initial performance wasnt that great. Things might have changed tho...

dbemiller commented 6 years ago

PBS doesn't support "innate" aliases. All the aliases are defined on-the-fly in the request.

We may build some hardcoded aliases into PBS in the future... but there are some very good reasons not to, and I didn't see much value in it since the prebidServerBidAdapter in PBJS could secretly slip them in without bothering publishers anyway.

So... the alias would go into the PBJS adapter.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dmitriyshashkin commented 6 years ago

So what's the current situation with this issue? What is the proposed solution?