prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.33k stars 2.09k forks source link

How to integrate DFP Express Module #3178

Closed soman closed 5 years ago

soman commented 6 years ago

Type of issue

question

Description

DFP Ad does not trigger when i have using pbjs.express();

Test page

http://stage.thisoldhouse.com/header_bidder/test_prebid_appnexus_with_dfp_express.html

Expected results

I need to integrate DFP Express module with prebid version 1.18.0

bretg commented 6 years ago

You're right @soman, our Express module documentation left a lot to be desired. I've updated it. Please take a look at http://prebid.org/dev-docs/modules/dfp_express.html, particularly the new example, to see if it answers your questions.

headerbidding commented 6 years ago

@bretg Could you please explain what DFP Express is. I use DFP (now called GAM) but I am mot familiar with the "Express" part. I did a search, but could not find a definition. Please explain.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

headerbidding commented 5 years ago

What is DFP Express? I did a search, but could not find a definition. Can anyone explain???

bwoolcott commented 5 years ago

@headerbidding The DFP Express module documentation is linked above (http://prebid.org/dev-docs/modules/dfp_express.html) and the actual module code is here: https://github.com/prebid/Prebid.js/blob/master/modules/express.js

headerbidding commented 5 years ago

@bwoolcott Yes, I had looked at it. Unfortunately it does not explain what DFP Express is.

bretg commented 5 years ago

@headerbidding - I'm open to ideas as to how to improve this page, but it does explain that Express is "a simplified alternate installation mechanism for publishers that have Google Publisher Tag (GPT) ad calls in their pages."

It then goes on to list the key points:

So - please help us understand what concept needs to be better defined.

headerbidding commented 5 years ago

Reading it over again, I finally understood it. Thank you!

Suggestion: It would keep it more simple and consistent to replace "DoubleClick" with "GAM/DFP"

bretg commented 5 years ago

Good to hear. It's on our list to update the site to deal with the DFP name change... will handle "DoubleClick" then as well. Thanks.

andreadd commented 4 years ago

Thank you, very useful. So using the express module I don't have to create any order or creativity for Prebid in DFP? Ad units are enough? I just implemented the "minimal example".

Another thing, I think you forgot something here at the end, brackets are unbalanced.

2) Append the following lines to the file:

var adUnits = [
  {
    code: '/111111/slot-name',
    mediaTypes: {
      banner: {
        sizes: [[300,250]]
      }
    },
    bids: [
    {
      bidder: 'rubicon',
      params: { account: 1001, siteId: 113932, zoneId: 535510 }
    }
  }];
pbjs.express(adUnits);

Shouldn't it be instead:

      params: { account: 1001, siteId: 113932, zoneId: 535510 }
    },]
  }];
pbjs.express(adUnits);

Thank you!