search

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.28k stars 2.05k forks source link

Teads: Adapter doesn't respect media types - sizes don't work #3373

Closed muuki88 closed 5 years ago

muuki88 commented 5 years ago

Type of issue

bug

Description

The Teads Adapter, still uses the deprecated bid.sizes property and doesn't differentiate between banner and video media types.

This

cc: @valsouche

Steps to reproduce

Use a video only ad unit. See #3222

Expected results

Teads should use the mediaTypes sizes for video and/or banner instead of the deprecated sizes property.

Platform details

Other information

muuki88 commented 5 years ago

This is especially weird as the bid.sizes property should include the videos sizes. At least if I read this code in der adapterManager.js correctly.

It almost looks as if the video player sizes override the banner.

The OpenX adapter handles the video playerSize explicitly.

muuki88 commented 5 years ago

The reasons for this behavior is buried in the getBids function, which simply used the mediaTypes.banner.sizes and discards everything that has been done before.

valsouche commented 5 years ago

In this pull request (https://github.com/prebid/Prebid.js/pull/3377), @bretg says that playerSize is an optional field. But like @muuki88 said, for some reason, if from a video adunit mediatypes there is no playerSize, bid sizes equals[], even if there is a sizes property on the adUnit.

It looks like only banner sizes are copy in adUnit.sizes.

When mediaTypes.video there is only a check on playerSize (in adapterManager.js) and no on mediaTypes.video.sizes, why ? And why bid sizes property could contains only banner or [] here: https://github.com/prebid/Prebid.js/blob/master/src/adaptermanager.js#L97 ? It means bid.sizes is only available for banner.

Is it something expected ? Should we explicitly check each sizes possibility from adapter ?

Thanks in advance, Val.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

muuki88 commented 5 years ago

Before this ticket is getting stale.

@valsouche are opening a PR to fix this?

muuki88 commented 5 years ago

Should be fixed in the next release.