OpenX Adapter's video `openrtb` parameter doesn't behave as documented

[DecayConstant]

Type of issue

Bug in OpenX Adapter or incorrect documentation about the video openrtb parameter.

Description

The documentation for OpenX video bid requests (Here: https://docs.openx.com/Content/developers/containers/prebid-video-adapter.html and here: https://github.com/prebid/Prebid.js/blob/master/modules/openxBidAdapter.md ) indicates that the proper structure of the requests looks like this:

var videoAdUnit = {       
   code: 'video1',
   mediaTypes: {
      video : {
         playerSize: [640, 480],
         context: 'instream'
      }
   }, 
   bids: [{            
      bidder: 'openx',             
      params: {
         unit: '1611023124',
         delDomain: 'PUBLISHER-d.openx.net',
         openrtb:{
           imp: [{
             video: {
               mimes: ['video/x-ms-wmv, video/mp4']
            }
          }]
        }
      }                      
   }]     
};

However, this does not work. Both the OpenX Adapter code and the the OpenX tests indicate this is the correct format:

params: {
     unit: '1611023124',
     delDomain: 'PUBLISHER-d.openx.net',
    // undocumented `video` object wraps `openrtb`
     video: {
       openrtb:{
         imp: [{
           video: {
             mimes: ['video/x-ms-wmv, video/mp4']
          }
        }]
      }
    }
} 

As a result, setting up openrtb according to the documentation does nothing. There also seems to be more undocumented behavior related to the contents of video. So either the code needs to be updated to match the documentation, or the documentation needs to change to match the code.

Steps to reproduce

Try to use the openrtb parameter on an OpenX video bid request as documented.

[jsnellbaker]

Hi @jimee02 @lambdarho @lu-ruo,

Based on looking back at some commits for the OpenX Adapter, would one of you be able to review the issue above and put together a fix (if needed)? If you know of a more ideal contact, can you please tag them here?

Thanks!

[jimee02]

@jsnellbaker and @DecayConstant , I can take a look at this.

[jimee02]

@DecayConstant, I've created a ticket to updated our docs page and have updated prebid and our adapter to match the code.

[jimee02]

@jsnellbaker, can we consider this issue closed?