Closed mhipszki closed 8 years ago
@mhipszki I think this is a useful feature. Happy to review a PR for this! Thanks
@mkendall07 awesome, I'll submit a PR soon then!
so, here's the PR, however I slightly changed (reduced) the scope
adapters.json
contains only the list of available adapters to be used as default when bundling@mkendall07 could you please take a closer look and let me know if it complies with prebid.js standards?
I've tried to separate the solution as much as I could, also described how to use the feature in README.
this is merged.
Hey guys,
we're integrating header bidding into our site currently and we've found
prebid.js
as a really nice and simple way to add this feature.However we couldn't figure the best way to actually include the prebid bundle into our project.
We're considering:
We'd prefer to explicitly show to our devs that we're using
prebid.js
(in ourpackage.json
) and to build our custom bundle from source rather than to check in a downloaded version. We also need to automate the building of the bundle, containing only the adapters we need.The issue is that we couldn't find a way to build the custom bundle with the selected adaptors with the provided
gulp
tasks, apart from hacking the project'spackage.json
which is kind of an unmaintainable solution.Separating the build related configuration first would probably make sense, but to make the build process "context independent", reproducible and simple it'd be great to see an option e.g. on the gulp task to specify an external config file e.g.
where
build-config.json
would contain e.g. the adaptersalso, it'd be great to specify the build target path e.g.
We're happy to fork the project and provide the feature in a PR as others might utilise it as well.