prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.28k stars 2.05k forks source link

33accross is not working through PBS #4559

Closed alejandrofcarrera closed 4 years ago

alejandrofcarrera commented 4 years ago

Type of issue

Bug about bidder

Description

Regarding with another issue we have seen at the end of the testing that 33accross is throwing an exception when we enable it. I saw this another issue that it was closed automatically and might be the same issue but now there is a live example to test it.

Steps to reproduce

Open the provided link and check the console.

Test page

https://ebook.education.investing.com/pbs/33accross.html?pbjs_debug=true

Expected results

No exceptions.

Actual results

ERROR: TypeError: Cannot read property 'bidId' of undefined

Platform details

Prebid.js v2.43.0 Prebid Server adapter + 33accross configuration.

Other information

This website is working well.

bretg commented 4 years ago

I sent email to the Prebid Server adapter maintainer alias for 33across. Also, maybe @thomas-33across can route this request?

thomas-33across commented 4 years ago

Hello @bretg we will look into the issue, thank you

thomas-33across commented 4 years ago

Hello @alejandrofcarrera can you give me the stack trace of the error? since the test page is minified version of prebid.js, it's hard to do debug there. Thank you

alejandrofcarrera commented 4 years ago

Yes. Even better, i unminified the pbjs bundle, so you can see it on (console) the above link.

Anyway, this is the trace:

ERROR: TypeError: Cannot read property 'bidId' of undefined
    at fill_server_issue.html?pbjs_debug=true:7838
    at Array.forEach (<anonymous>)
    at fill_server_issue.html?pbjs_debug=true:7794
    at Array.forEach (<anonymous>)
    at Object.interpretResponse (fill_server_issue.html?pbjs_debug=true:7793)
    at fill_server_issue.html?pbjs_debug=true:7898
    at Object.success (fill_server_issue.html?pbjs_debug=true:7915)
    at XMLHttpRequest.onreadystatechange (fill_server_issue.html?pbjs_debug=true:3061)
thomas-33across commented 4 years ago

@alejandrofcarrera Thank you for unminified the bundle, and provide the trace. The issue is not related to Prebid, but more of how our exchange handle the test bid case. when our exchange see the test:1 in the request, we will randomly generate a impid to short circuit the test process. But this issue will not happen in Porduction. we will create an internal ticket to fix the issue on our end. Thank you

alejandrofcarrera commented 4 years ago

I can say, this development URL without any field like debug is working with 33accross adapter. https://ebook.education.investing.com/pbs/33accross.html Can you check on your side if you are getting a good response ?

Also, can you send me an email with your corporate address to talk privately about user_sync with 33accross ? > alejandro.f@investing.com

Thanks @thomas-33across 👍

alejandrofcarrera commented 4 years ago

btw @thomas-33across, why when i am adding pbjs_debug=true you are returning a test case ? in theory this query param is to enable debug logs on pbjs client side and no more.

bretg commented 4 years ago

This gets into a pending feature within Prebid Server and the PrebidServerBidAdapter.

https://github.com/prebid/prebid-server/issues/745

Prebid Server Java currently supports two different flags on the request:

Once the Go version of Prebid Server supports ext.prebid.debug, we will have a decision to make about how PBJS should handle ?pbjs_debug=true.

thomas-33across commented 4 years ago

@alejandrofcarrera you can send an email to headerbidding@33across.com to initiate the discussion. Thank you

alejandrofcarrera commented 4 years ago

Understood @bretg what do you suggest ? Use the Java version or keep using the Go version, because i don't know if there is any way to enable debug mode on the server without sending this kind of flags, would be great.

I think we can close the issue when @thomas-33across fixes on their side the sending of unhandled parameters when test:1 is sent throught PBS.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bretg commented 4 years ago

Adding @SyntaxNode to prioritize for PBS-Go in 2020.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.