prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.28k stars 2.05k forks source link

Gzip compression on library scripts #468

Closed protonate closed 7 years ago

protonate commented 8 years ago

Recent performance audits show that a number of scripts could be gzipped to improve overall performance.

The following scripts are not gzipped. If possible please gzip your libraries.

@prebid/springserve @prebid/aol @prebid/rubicon

@sekindo @nedstankus @sethyates @devmusings

protonate commented 8 years ago

Also please reply to this issue when the gzipped version is in place.

sekindo commented 8 years ago

We will take care of it early next week Thanks

From: Nate Guisinger [mailto:notifications@github.com] Sent: Saturday, July 23, 2016 1:00 AM To: prebid/Prebid.js Cc: Eyal Betzalel; Mention Subject: Suspect Spam - Marketing Mail Re: [prebid/Prebid.js] Gzip compression on library scripts (#468)

Also please reply to this issue when the gzipped version is in place.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/prebid/Prebid.js/issues/468#issuecomment-234667479, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASZM9nVdrJsTOyjBweubh7KEmzeBdLwnks5qYT1JgaJpZM4JTKi0.

sekindo commented 8 years ago

Done! (sekindo liveView)

From: Nate Guisinger [mailto:notifications@github.com] Sent: Saturday, July 23, 2016 1:00 AM To: prebid/Prebid.js Cc: Eyal Betzalel; Mention Subject: Suspect Spam - Marketing Mail Re: [prebid/Prebid.js] Gzip compression on library scripts (#468)

Also please reply to this issue when the gzipped version is in place.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/prebid/Prebid.js/issues/468#issuecomment-234667479, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASZM9nVdrJsTOyjBweubh7KEmzeBdLwnks5qYT1JgaJpZM4JTKi0.

indexexchange commented 8 years ago

@protonate -- the IndexExchange bidding endpoint should have gzip compression enabled:

Request URL: http://as.casalemedia.com/headertag?v=9&x3=1&fn=cygnus_index_parse_res&s=....

GET /headertag HTTP/1.1 Host: as.casalemedia.com Accept-Encoding: gzip, deflate

< HTTP/1.1 200 OK < Server: Apache < Vary: Accept-Encoding < Content-Encoding: gzip < Content-Length: 2859 < Content-Type: text/javascript

Can you clarify on which requests you were not able to achieve compression?

protonate commented 8 years ago

I'm not seeing a content-encoding response header for the ./headertag resource.

$ curl -I -L -H 'Accept-Encoding: gzip, deflate' http://as.casalemedia.com/headertag?v=9&x3=1&fn=cygnus_index_parse_res&s=
[1] 81963
[2] 81964
[3] 81965
[2]   Done                    x3=1
[3]+  Done                    fn=cygnus_index_parse_res

ncozi at ncozi in ~
$ HTTP/1.1 301 Moved Permanently
Date: Wed, 27 Jul 2016 16:15:10 GMT
Server: Apache/2.2.15 (CentOS)
Access-Control-Allow-Origin:
Access-Control-Allow-Credentials: true
Access-Control-Allow-Methods: POST, GET, OPTIONS, DELETE, PUT
Access-Control-Max-Age: 1000
Access-Control-Allow-Headers: X-Requested-With, Content-Type, Origin, Authorization, Accept, Client-Security-Token
Location: http://as.casalemedia.com/headertag/?v=9
Connection: close
Content-Type: text/html; charset=iso-8859-1

HTTP/1.1 200 OK
Date: Wed, 27 Jul 2016 16:15:10 GMT
Server: Apache/2.2.15 (CentOS)
Access-Control-Allow-Origin:
Access-Control-Allow-Credentials: true
Access-Control-Allow-Methods: POST, GET, OPTIONS, DELETE, PUT
Access-Control-Max-Age: 1000
Access-Control-Allow-Headers: X-Requested-With, Content-Type, Origin, Authorization, Accept, Client-Security-Token
Connection: close
Content-Type: application/json

cc: @indexexchange

indexexchange commented 8 years ago

@protonate -- I'm seeing something different (I quoted the URL since it contains ampersands which the shell doesn't like):

roni@rgordon:~$ curl -I -L -H 'Accept-Encoding: gzip, deflate' 'http://as.casalemedia.com/headertag?v=9&x3=1&fn=cygnus_index_parse_res&s='
HTTP/1.1 200 OK
Server: Apache
Vary: Accept-Encoding
Content-Encoding: gzip
Content-Length: 20
Content-Type: text/javascript
X-N: S
Expires: Thu, 28 Jul 2016 16:25:07 GMT
Cache-Control: max-age=0, no-cache, no-store
Pragma: no-cache
Date: Thu, 28 Jul 2016 16:25:07 GMT
Connection: keep-alive
protonate commented 8 years ago

Ah, I was redirecting to development, apologies, I'm seeing a gzipped response for the ./headertag endpoint.

mkendall07 commented 7 years ago

Bump on this. Any adapter updates?

bretg commented 7 years ago

The RubiconProject endpoint will start rolling out compression support mid-late January... QA in progress.

protonate commented 7 years ago

The AppNexus /jpt endpoint is now has compression enabled.

mkendall07 commented 7 years ago

This is requirement in prebid 1.0

matan-ybrant commented 7 years ago

Brightcom is now gzipped.