search

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.28k stars 2.05k forks source link

client-side adapter code should not be required for server-side bidders #6388

Closed spormeon closed 3 years ago

spormeon commented 3 years ago

I just updated to 4.29.0 from the download page UI and I don't think "prebid server" is being included in the download? client side bidders work ok, but nothing/ zip for "auction"

DevTools_-_ads_vsvl_co_uk_pub000020_scripts_AMPTEST4_29_0_html_and_Download_Prebid_js_for_Header_Bidding

bretg commented 3 years ago

@spormeon - download of the pbsBidAdapter works for me.

search for a string in your package known to be within an adapter like "Incorrect or unavailable prebid server default vendor option"

What's the last version you were on? There've been a few changes in the pbsBidAdapter but nothing that should be backwards compatibility breaking. There is one bug in aliases that might affect behavior - see https://github.com/prebid/Prebid.js/issues/6336

spormeon commented 3 years ago

i was on 4.20 before ( my "live" instances are on this), I tried 4.28 as well, and seeing same result, its throwing a big chunk of warnings, its exactly the same setup as on "live" instances:

DevTools_-_ads_vsvl_co_uk_pub000020_scripts_AMPTEST4_29_0_html

spormeon commented 3 years ago

hang on, have you now got to also include the actual adapters of each of the bidders?

bretg commented 3 years ago

I've seen this message recently. It means your PBJS package doesn't have these bidders in them. Please verify your download/build of the package worked properly.

spormeon commented 3 years ago

i'm only adding the adapters of the bidders that are "client" side, as before when using prebid server you didn't have to included the adapters of the prebid server bidders

bretg commented 3 years ago

before when using prebid server you didn't have to included the adapters of the prebid server bidders

I thought it's been that way forever, which is why I recently opened the issue Remove requirement for client-side adapter to run server-side

@ChrisHuie, please hunt down what changed here?

Without the adapter code, PBJS doesn't know the mediatypes, permanent aliases, or GVL ID.

spormeon commented 3 years ago

if i build with the server side bidders adapters included, it works. I've built without the s2s adapters being included for months back and it worked fine. To keep the file size as small as possible, now I have to "bloat" it back up again.

ChrisHuie commented 3 years ago

I think I have narrowed this down to the 4.24 release in adding multiple prebid server support #5992

nerra0pos commented 3 years ago

Just to clarify for a newby: Is it required to add the vendor adapters in addition to the "Prebid Server" module for the ones that we only request bids via S2S or not? We always added them, but now I read here it's not. Confusing.

bretg commented 3 years ago

@terrapop - the goal is that client-side code should not be required to run an adapter server-side. Currently it is.

nerra0pos commented 3 years ago

Thank you for the clarification @bretg, so we're doing it correctly then.

bretg commented 3 years ago

We discussed in PBJS meeting yesterday -- @snapwich is going to take a look at webpack to see if there's a way to surface just the aliases, mediatypes, and gvl IDs when an adapter is server-side

gglas commented 3 years ago

@snapwich were you able to take a look at this? I will also add to this week's PMC.

snapwich commented 3 years ago

@gglas i did some investigation and commented in https://github.com/prebid/Prebid.js/issues/6361#issuecomment-811494883

I think this ticket is probably a duplicate?

ChrisHuie commented 3 years ago

closing as duplicate of #6361