gglas commented 3 years ago

In conjunction with https://github.com/prebid/Prebid.js/issues/6466 , there will be an expectation going forward that adapters at least have a method to pass meta.advertiserDomains in their bid responses. This is because in the future we expect publishers and vendors to use the adomain(s) in service of any number of business cases.

This is not a hard requirement to pass adomain, however, adapters at least need to have a stub to pass adomain in the appropriate field (the meta.advertiserDomains field). The following adapters have no mention of adomain or advertiserDomains, and while some adapters may be modified with the appropriate stub by other prebid members, any adapters on this list should ensure that they support the relevant field in their adapter or risk not being ported to 5.0.

If you believe you have been included in error, please ping the thread and we will remove you from the list. We expect enforcement to take the form of non-porting to 5.0, which will commence at the end of May.

patmmccann commented 3 years ago

See #6495 ; did you run the most recent list?

dliebner commented 3 years ago

Is there documentation for this requirement?

patmmccann commented 3 years ago

Is there documentation for this requirement?

https://github.com/prebid/Prebid.js/issues/5966 and https://prebid.org/blog/prebid-js-release-4-0/

curlyblueeagle commented 3 years ago

33acrossBidAdapter will address this shortly. Is there a deadline?

gglas commented 3 years ago

We expect 5.0 to be released at the end of May. Updating the issue to reflect this.

bjorn-lw commented 3 years ago

@gglas The Livewrapped adapter fills the "meta" field with data from our front end servers, including "advertiserDomains": https://github.com/prebid/Prebid.js/blob/679793586b68692a312034b686d9b48d1f35afbc/modules/livewrappedBidAdapter.js#L130

cesarfd commented 3 years ago

@gglas axonixBidAdapter gets the response complete with the meta object from our own servers.

bokos commented 3 years ago

@gglas meta.advertiserDomains is included in the server response for ablidaBidAdapter, so it does not need to be assigned in the adapter https://github.com/prebid/Prebid.js/blob/master/modules/ablidaBidAdapter.js#L70

pratik-synacor commented 3 years ago

@gglas SynacorMedia adapter does support meta.advertiserDomains https://github.com/prebid/Prebid.js/blob/master/modules/synacormediaBidAdapter.js#L259-L261 Is it added to the list by mistake?

rokostik commented 3 years ago

Hey @gglas, both the Zemanta adapter (scheduled for deletion in prebid 5) and its replacement, the Outbrain adapter support meta.advertiserDomains (Zemanta code, Outbrain code). This was done in https://github.com/prebid/Prebid.js/pull/6517. Can you confirm that everything is ok from our end?

desidiver commented 3 years ago

Hi @gglas , Yieldmo adapter supports this and it seems to be added to this list by mistake. https://github.com/prebid/Prebid.js/blob/master/modules/yieldmoBidAdapter.js#L215 Thank you.

sebaperez commented 3 years ago

E-Planning (eplanningBidAdapter) already supports it: https://github.com/prebid/Prebid.js/pull/6832

AdmixerTech commented 3 years ago

PR #6674. Is it still issue for Admixer ?

Skylinar commented 3 years ago

smartx Bid Adapter already supports it: #6547 Please confirm.

ignat-one commented 3 years ago

Hi! We have supported advertiserDomains in BetweenBidAdapter: #6791

patmmccann commented 3 years ago

Hi @gglas , Yieldmo adapter supports this and it seems to be added to this list by mistake. https://github.com/prebid/Prebid.js/blob/master/modules/yieldmoBidAdapter.js#L215 Thank you.

@desidiver I see your fix on #6550 and you're not on this running list but you are on #6512

readpeaktuomo commented 3 years ago

Hi @gglas! PR https://github.com/prebid/Prebid.js/pull/6548 addressed this for readpeakBidAdapter. Please let us know if more is required.

desidiver commented 3 years ago

Hi @gglas , Yieldmo adapter supports this and it seems to be added to this list by mistake. https://github.com/prebid/Prebid.js/blob/master/modules/yieldmoBidAdapter.js#L215 Thank you.

@desidiver I see your fix on #6550 and you're not on this running list but you are on #6512

@patmmccann for #6512 We need to update our documentation but as I understand it the code changes are all there. Thank you.

matthieularere-msq commented 3 years ago

Hi,

PR #6843 added support of advertiser domains for mediasquareBidAdapter

ghost commented 3 years ago

@gglas gjirafaBidAdapter and malltvBidAdapter are now compliant

6853 #6854

susyt commented 3 years ago

hi, does PR #6478 satisfy the support or are more modifications needed?

andrzejgemius commented 3 years ago

Hello. #6872 adds support for advertiserDomains to the Adocean adapter.

stsepelin commented 3 years ago

Hi. #6875 adds support for advertiserDomains to the CointrafficBidAdapter.

itaynave commented 3 years ago

@gglas Aniview Bid Adapter: added meta.advertiserDomains to bidResponse and extended cookie sync logic #6858

Giudici-a commented 3 years ago

Hi, #6876 adds support for advertiserDOmains to the AdotBidAdapter.

ckbo3hrk commented 3 years ago

Hi, #6899 adds support to adkernelAdn adapter

hybrid-ai commented 3 years ago

Hi,

6885 adds support for advertiserDomains to the hybridBidAdapter.

6884 adds support for advertiserDomains to the voxBidAdapter.

guiann commented 3 years ago

Done forAdYouLike bidder adapter with: https://github.com/prebid/Prebid.js/pull/6916

Merged into prebid 4.42.0.

rrelict commented 3 years ago

Hi, #6936 adds support for advertiserDomains to visxBidAdapter.

VanCyric commented 3 years ago

Hi, adomain support for buzzoolaBidAdapter is implemented on a server side. You can see the demo here: https://demo.buzzoola.com/prebidjs/

zcundiffoiq commented 3 years ago

The inmarBidAdapter is passing the advertiserDomains field inside the "meta" object. This object is set in our adapter here. Rather than set the meta fields individually in the adapter, it made more sense to format the whole object on our servers and pass it in a completed state. Is this good, or is there anything else we need to pass version 5.0 verification?

patmmccann commented 3 years ago

The inmarBidAdapter is passing the advertiserDomains field inside the "meta" object. This object is set in our adapter here. Rather than set the meta fields individually in the adapter, it made more sense to format the whole object on our servers and pass it in a completed state. Is this good, or is there anything else we need to pass version 5.0 verification?

You are good, thanks!!

couchcrew-thomas commented 3 years ago

@gglas @ChrisHuie Just got this one forwarded. FeedAd creates the response object on the server side. https://github.com/prebid/Prebid.js/blob/master/modules/feedadBidAdapter.js#L232

Can you please take us off this list? Thanks.

patmmccann commented 3 years ago

Feedad is gtg, thanks!

monis0395 commented 3 years ago

Hi @patmmccann , hope you are doing good!

Adomain support for medianetBidAdapter is implemented on a server side. Here is a live screenshot

Let me know if you more details.

Thanks!

patmmccann commented 3 years ago

media.net was no longer on the list, #6986 is the official list and this issue will close as it gets merged

prebid / Prebid.js

Adapter does not seem capable of supporting advertiserDomains #6650

6853 #6854

6885 adds support for advertiserDomains to the hybridBidAdapter.

6884 adds support for advertiserDomains to the voxBidAdapter.