search

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.33k stars 2.09k forks source link

MerkleId NOT handled properly for OpenX (Easy Fix) #7566

Closed DemonFangs closed 3 years ago

DemonFangs commented 3 years ago

After recent Merkle ID module update the merkle id is not extracted properly from the Apenx adapter.

see here

Solution: Add new case:

case 'merkleid':
    queryParams[key] = userIdObjectOrValue.id;
    break;
SKOCHERI commented 3 years ago

There has been no changes/updates to the way how merkle id was returned from MerkleIdSystem.js. Agree to the fact that Apenx adapter needs to handle merkle id.

patmmccann commented 3 years ago

seems like this

https://github.com/prebid/Prebid.js/blob/424d9a091c8ae5fb04632243acac8aa09f00a054/modules/openxBidAdapter.js#L326

should be case flocid or merkle or uid2

bwschmidt commented 3 years ago

fixed in https://github.com/prebid/Prebid.js/pull/7576

DemonFangs commented 3 years ago

👍