search

prebid / Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.
https://docs.prebid.org
Apache License 2.0
1.28k stars 2.05k forks source link

description_url not set on video request when Prebid cache.url is set #9227

Closed nanek closed 1 year ago

nanek commented 1 year ago

Type of issue

Bug

Description

Unable to pass a description_url for video ad request to google when cache.url is set.

description_url should always be set, and Prebid is setup to set it if one is not provided. https://docs.prebid.org/dev-docs/publisher-api-reference/adServers.dfp.buildVideoUrl.html

However if you pass it to buildVideoUrl as an option or not, description_url will never get set on the gampad request if you have a prebid config containing a cache.url. I use a cache.url, so this does not get set.

https://github.com/prebid/Prebid.js/blob/master/modules/dfpAdServerVideo.js#L257 is the code in question. It seems valid to me to be able to set a cache.url and have a description_url passed on the gampad request.

Steps to reproduce

set cache.url to something, and no description_url will be set on the gampad request.

Test page

Expected results

cache.url can be set, and description_url is set on gampad request.

Actual results

Platform details

Prebid 7.18

Other information

https://support.google.com/admanager/answer/10678356?hl=en#description_url https://support.google.com/admanager/answer/1734048?hl=en

karimMourra commented 1 year ago

acknowledging that this is a bug; I think at some point there was a misunderstanding regarding description_url. Per google documentation:

The description URL should typically be the same as the referrer URL.

So cache.url is irrelevant