search

prebid / prebid-mobile-android

Prebid Mobile SDK for Android applications
Apache License 2.0
57 stars 82 forks source link

AdViewUtils.findPrebidCreativeSize pollutes logcat with an unnecessary warning when no size object found #725

Open justadreamer opened 9 months ago

justadreamer commented 9 months ago

Describe the bug If Prebid creative loses and some other creative served AdViewUtils.findPrebidCreativeSize would fail to find hb_size:<size> in the creative and would log a warning: 

errorCode:240 errorDescription:The HTML doesn't contain a size object

The logging happens here.

However this is not an error per se - the creative may or may not contain hb_size. If it does not contain a size object - it simply means it is not a Prebid Universal Creative. Thus it should be at max an info level message, not a warning level and it should read: The HTML does not appear to be a Prebid Universal Creative, as it does not contain an hb_size snippet.

To Reproduce Steps to reproduce the behavior:

  1. Load and render any banner creative (a test ad in Google Mobile Ads SDK would do) that would be not a universal creative
  2. Call AdViewUtils.findPrebidCreativeSize on the bannerView
  3. Observe a warning message logged

Expected behavior The info level message as suggested above is logged.

Screenshots image

Smartphone (please complete the following information): Any Android.

jsligh commented 4 months ago

@justadreamer is this still an issue?

justadreamer commented 3 months ago

Hi @jsligh yes this is still an issue, but very minor (cosmetics), can be handled with low priority.