prebid / prebid-mobile-ios

Prebid Mobile SDK for iOS applications
Apache License 2.0
46 stars 87 forks source link

VAST Wrapper 2.0 URL parsing issue #897

Open maddapper opened 1 year ago

maddapper commented 1 year ago

Describe the bug During VAST URL Wrapper parsing, there is an issue with URL creation:

[‼️][PrebidServerConnection.swift]:237 createRequest(_:) -> URL creation failed for string: https://sjc-usadmm.dotomi.com/fetch/vanilla/player/video/vast/2_0?comId=21965&fpc=0&msgCampId=36548&pnid=1982&ptid=37058&tid=45552&cg=91&parentMsgID=36547&ms=51&apis=0&bidServerId=${BIDSERVERID}&cturl=&dtm_server_id=5411&dtmid=398680955334037074&iblob=gv2cyp9COT3spP6z532PRDZu4WMnDEaHU1leGljYW4gVHJhaW4gRG9taW5vZXMgRGVsdXhlIgc2MzA5MTI0Kgk1MDcyOTE5MjIwADokM0YzNkEwMzgtMkE0RC00QjkwLUE2MDItRTZBMjU1NUFGRjBEUgVBcHBsZVoGaVBob25leACCAQ4xNzIuMjUxLjYwLjEwOaABAaoBBDcxMjW4AQPAAfu-vaD05NztBMgB____________AdABAOABCegB2P768KaPqf5b8wEKAlVTEgJVUxj-ASICQ0EoBTILU0lNSSBWQUxMRVk4gBhApQZIowZQowZaBTkzMDYzYIfXBW17FAlCdYVr7cJ6EkxFVkVMIDMgUEFSRU5UIExMQ5IBBVdJUkVE9AH7AQoCVVMSAlVTGP4BIgJDQSgFOIAYUKMGWgU5MzA2M_wBggIIMjcwOTc5NDGIAv___________wGYAgGgAgCoAsKhArACAMACAsoCOjEwNTE1MTUxMDJ8NjU4NTE3MzMxfDE3NjIxODk0MTF8MzY3MDExOTk4fDc1MDgyMDI4MXwwfC0xfDDoAgvzAgiXxxgQ-svKxdYwGgExIQAAAAAAAAAAKQAAAAAAAPA_9AL5AgAAAAAAAADAgQP7XG3F_rLlP4kDpyVWRiOf5T-RAwAAAAAAAPC_mQMAAAAAAADwv6EDAAAAAAAA8L-pAwAAAAAAAPA_sAMB8gMDVVNE-QMAAAAAAADwv4EEAAAAAAAANUCJBArXo3A9Ctc_kQQK16NwPQrXP5kEda_giON91D6gBJDNyb2ZMagEqIgNsATiA7kEEvrVZfoYp0DBBOeOgIbfVJE_6QQAAAAAAAAAAPEEAAAAAAAAAAD4BACCBQlBcHBsZSBpT1OIBQCQBQGYBQOoBQCxBQAAAAAAAAAAuQUAAAAAAAAAAMEFAAAAAAAA8L_JBQAAAAAAAAAA0AUA2AUA6QUAAAAAAAAAAPEFAAAAAAAAAAD5BQAAAAAAAAAAggYCSVCYBv___________wGoBgCwBgG4BgDABgQ&icb=0&magic=42&mwp=${AUCTION_PRICE}&pid=1982&rt=4&supplyType=3&trid=4462071621375278052&vcskippable=false&vrp=5&ctrl_ad_id=5&cgcb=-1&count=true&nopd=1&

To Reproduce Steps to reproduce the behavior:

  1. Setup Video Interstitial stored impression
  2. Using interstitial rendering ad unit
  3. Call loadAd
  4. See error

Expected behavior No parsing error should happen and video interstitial should render.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

YuriyVelichkoPI commented 1 year ago

Hi @maddapper! Thanks for the report!

The reason for the error is macros AUCTION_PRICE and BIDSERVERID that SDK doesn't resolve.

Could you share the full stored impression that you use so we are on the same page?

And please, let us know which exact processing of these macros is expected, because for now, I can't find any info on how to resolve BIDSERVERID.

If you don't use the rendering API but Original API + GAM does this VAST tag work and macros are substituted?

YuriyVelichkoPI commented 1 year ago

@maddapper, also please share the full bid request and bid response in your example, so we can see targeting keywords and other details.

maddapper commented 1 year ago

thanks for looking into this, let me try to get more info re: stored impression and bid request / response

jsligh commented 2 months ago

@maddapper is this still an issue or has this been resolved?