search

prebid / prebid-mobile-ios

Prebid Mobile SDK for iOS applications
Apache License 2.0
47 stars 89 forks source link

Remove data from request as its already contained on the uploadTask #955

Closed aiFigueiredo closed 7 months ago

aiFigueiredo commented 7 months ago

This PR is to address issue #920 where an error is shown onsession.uploadTask when the request contains a body.

As the title states, the data should not be required in the request as its already passed to the uploadTask method.

aiFigueiredo commented 7 months ago

@OlenaPostindustria, @YuriyVelichkoPI can I get some 👀 on this? 🙏

jsligh commented 7 months ago

@aiFigueiredo Apologies, I'm just now seeing this. I believe this should fix the issue and should not affect the uploadTask negatively as you previously stated because the body is already part of the upload task.

aiFigueiredo commented 7 months ago

Thanks @jsligh, what do we need to get this merged in and on a new release? I assume this will affect all clients that use this SDK and support the latest iOS version

jsligh commented 7 months ago

@aiFigueiredo I am merging this and hope to get a new build out next week sometime once a couple more PR's have been reviewed and merged.

aiFigueiredo commented 7 months ago

Thanks @jsligh, appreciate the 👀 and the info.