Closed ankit-thanekar007 closed 4 months ago
Hi, I wanted to know if we can remove the deprecated API.
https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/Utilities/PBMUIApplicationProtocol.h
Is it used for tests ?
https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobileTests/RenderingTests/Mocks/MockUIApplication.swift
The reason I ask is because this is causing warnings in multiple projects for us, because it thinks that we're using
UIApplication.openURL(): https://developer.apple.com/documentation/uikit/uiapplication/1622961-openurl
UIApplication.openURL():
Instead of
UIApplication.open() https://developer.apple.com/documentation/uikit/uiapplication/1648685-open
UIApplication.open()
because the automatic Swift bridging is picking up the protocol from PBMUIApplicationProtocol.h and renaming it to UIApplication.open()
PBMUIApplicationProtocol.h
For solution we can do the following :
Any other solution is welcomed as well.
@YuriyVelichkoPI @jsligh
We can also move it to Swift and make it internal only so it doesn't affect the client apps.
Hi, I wanted to know if we can remove the deprecated API.
https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/Utilities/PBMUIApplicationProtocol.h
Is it used for tests ?
https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobileTests/RenderingTests/Mocks/MockUIApplication.swift
The reason I ask is because this is causing warnings in multiple projects for us, because it thinks that we're using
UIApplication.openURL():
https://developer.apple.com/documentation/uikit/uiapplication/1622961-openurlInstead of
UIApplication.open()
https://developer.apple.com/documentation/uikit/uiapplication/1648685-openbecause the automatic Swift bridging is picking up the protocol from
PBMUIApplicationProtocol.h
and renaming it toUIApplication.open()
For solution we can do the following :
Any other solution is welcomed as well.
@YuriyVelichkoPI @jsligh