prebid / prebid-mobile-ios

Prebid Mobile SDK for iOS applications
Apache License 2.0
47 stars 89 forks source link

Fixed: App Crash on Ad Redirect to Unsupported URL Scheme #987

Closed weibel closed 4 months ago

weibel commented 4 months ago

Description

During click handling, an attempt to open SFSafariViewController could result in a crash with the error:

The specified URL has an unsupported scheme. Only HTTP and HTTPS URLs are supported.

This PR addresses the issue by adding a check for the URL scheme in the PBMSafariVCOpener class to ensure it only attempts to open URLs with "http" or "https" schemes. If the URL has an unsupported scheme, the SDK will now log an error message and prevent SFSafariViewController from opening the unsupported URL, thereby preventing the app from crashing.

Background

This issue occurs when an ad redirects to "about" or when a user quickly clicks on an ad as soon as it appears, causing the app to crash due to an uncaught NSInvalidArgumentException. The fix ensures the app handles unsupported URL schemes gracefully.

Changes

Added a check for the URL scheme in the PBMSafariVCOpener class. If the URL scheme is not "http" or "https", log an error message and do not attempt to open the URL in SFSafariViewController.

Fixes https://github.com/prebid/prebid-mobile-ios/issues/966