Fixes for Issue 981 - Githubissues

prebid / prebid-mobile-ios

Prebid Mobile SDK for iOS applications

Apache License 2.0

47 stars 89 forks source link

Fixes for Issue 981 #991

Closed ankit-thanekar007 closed 4 months ago

ankit-thanekar007 commented 4 months ago

Add NS_SWIFT_NAME to remove deprecated method warning.
Make changes for the same in MockUIApplication.swift

ankit-thanekar007 commented 4 months ago

Hi @jsligh @YuriyVelichkoPI, Is it possible to get this PR reviewed, merged & released in a patch release ?

jsligh commented 4 months ago

@ankit-thanekar007 We prefer to remove deprecated methods in major releases and the next will be 3.0 which will be released later this year.

ankit-thanekar007 commented 4 months ago

@jsligh I can add NS_SWIFT_NAME property here that can also fix the issue for a patch release and not remove any deprecated methods. Will that be okay?

- (BOOL)openURL:(nonnull NSURL*)url NS_SWIFT_NAME(openURL(url:)) NS_DEPRECATED_IOS(2_0, 10_0, "Please use openURL:options:completionHandler: instead") NS_EXTENSION_UNAVAILABLE_IOS("");

Would require 1 change in MockUIApplication.swift

jsligh commented 4 months ago

@ankit-thanekar007 that sounds like a good compromise. Please make the changes so I can test them.

ankit-thanekar007 commented 4 months ago

@jsligh Pushed the changes

ankit-thanekar007 commented 4 months ago

Thanks @jsligh for merging. Is there a date for patch release ?

jsligh commented 4 months ago

@ankit-thanekar007 not yet but I will let you know when we do.