prebid / prebid-outstream

Outstream Video Player
Apache License 2.0
8 stars 14 forks source link

Unknown option '--env.env=prod' when run build #44

Open sbonetclement opened 5 months ago

sbonetclement commented 5 months ago

Hello, I have followed the steps indicated for the installation

$git clone https://github.com/prebid/prebid-outstream.git
$cd prebid-outstream
$npm install
$npm run build

Without making changes to the code, when running npm run build I get this error:

> prebid-outstream@0.1.0-pre build
> webpack --config build-utils/webpack.config.js --env.env=prod   
[webpack-cli] Error: Unknown option '--env.env=prod'
[webpack-cli] Run 'webpack --help' to see available commands and optionsptions

My node version is v18.17.0

Please could you help me? Thanks

hogekai commented 1 week ago

Hello! I ran into that problem too, but I thought there was a destructive change due to a module update, so I went back and checked the latest commit to make sure. Then,

"devDependencies": {
    "@babel/core": "^7.10.4",
    "@types/jest": "^26.0.20",
    "babel-eslint": "^10.1.0",
    "babel-loader": "^8.1.0",
    "clean-webpack-plugin": "^3.0.0",
    "css-loader": "^4.0.0",
    "dotenv-webpack": "^2.0.0",
    "eslint": "^7.2.0",
    "eslint-loader": "^4.0.2",
    "eslint-plugin-import": "^2.22.0",
    "eslint-plugin-jsx-a11y": "^6.3.1",
    "html-webpack-plugin": "^4.3.0",
    "jest": "^26.2.2",
    "prettier": "^2.2.1",
    "style-loader": "^1.2.1",
    "ts-jest": "^26.5.3",
    "ts-loader": "^8.0.17",
    "typescript": "^4.2.2",
    "url-loader": "^4.1.0",
    "webpack": "^4.43.0",
    "webpack-bundle-analyzer": "^3.8.0",
    "webpack-cli": "^3.3.12",
    "webpack-conditional-loader": "^1.0.12",
    "webpack-dev-server": "^3.11.0",
    "webpack-merge": "^5.0.9",
    "webpack-visualizer-plugin": "^0.1.11"
 },

and then I changed the package.json to something like I hope this helps.

muuki88 commented 18 hours ago

Hi @hogekai

Thanks a lot for the info. Are you using this project actively?

hogekai commented 18 hours ago

Hi @muuki88

Unfortunately, we do not use this project.If it stopped working due to an automatic upgrade of a dependent library, it is because security concerns exist.

Instead, I recently developed my own library that can be used with outstream video ad renderers without the need for hosting, and proposed it with adapter development.

https://github.com/hogekai/in-renderer-js https://github.com/prebid/Prebid.js/pull/12507

I am planning to put this library in the Prebid documentation and would appreciate your input if you would.

muuki88 commented 17 hours ago

Hi @hogekai

This is amazing :star_struck: We inherited this project, but have very limited resources and need to actively maintain it. You already made your renderer open source and provide it under a permissive license ( MIT ), I think there's a way to move this project into the prebid namespace, if this is something you would be interested in.

I'll try to bring this up in a prebid video PMC (project management commitee), if yes.

hogekai commented 17 hours ago

Thank you!

I am highly motivated in the field of ad tech and am working towards developing an ad integration infrastructure for modern frameworks. If you can make this project a step toward getting involved with Prebid, I would be happy to provide resources.

Let me know if any action needs to be taken.

muuki88 commented 16 hours ago

That's awesome :heart: If you like, you can DM me on linked in and we can stay in contact.