prebid / prebid-server

Open-source solution for running real-time advertising auctions in the cloud.
https://prebid.org/product-suite/prebid-server/
Apache License 2.0
425 stars 730 forks source link

Expanding how to obtain account ID #1027

Closed bretg closed 5 years ago

bretg commented 5 years ago

Account ID is important but not always present

Account ID is becoming more important as evidenced by recent activity:

As of now, our definition of account ID has three components:

1) if ext.prebid.parentAccount is present, use that 2) else if site.publisher.id is present, use that 3) else if app.publisher.id is present, use that 4) else there's no account ID

There several types of requests that don't carry valid account ID:

Alternate methods of obtaining account ID

Rubicon has implemented a feature in our private fork of PBS-Java to obtain account ID by scanning imp[].ext.rubicon.params.account. This works as long as there's at least one ad unit where Rubicon is a bidder, but it's obviously not ideal.

A somewhat better way would be to have PBS look in the global ext.prebid.account. Then we could update stored request DB entries to contain the account. This would pose a problem if the SRID isn't globally unique (https://github.com/prebid/prebid-server/issues/1024), but is more elegant in the scenario where SRID is unique enough.

So the hunt path for account would become:

1) if ext.prebid.parentAccount is present, use that 2) else, if ext.prebid.account is present, use that 3) else if site.publisher.id is present, use that 4) else if app.publisher.is is present, use that 5) else there's no account ID

bretg commented 5 years ago

We discussed in the Prebid Server committee today and decided this feature isn't needed.

bretg commented 10 months ago

Note: dooh.publisher.id is also checked for account