prebid / prebid-server

Open-source solution for running real-time advertising auctions in the cloud.
https://prebid.org/product-suite/prebid-server/
Apache License 2.0
424 stars 723 forks source link

PBS KVPs for deals #2214

Closed bretg closed 7 months ago

bretg commented 2 years ago

Supporting deal targeting is currently inconsistent across Prebid.js, SDK, and AMP.

I've added a note to https://docs.prebid.org/prebid-server/features/pbs-deals.html to describe the difference, but we should discuss whether a new PBS behavior is warranted. I think it may be. This is somewhat related to the PBJS issue https://github.com/prebid/Prebid.js/issues/8130 , but I don't think we need major surgery on PBS.

Here are the current KVP controls in PBS:

Proposed new KVP flag: alwaysincludedeals

PBS could support a ext.prebid.targeting.alwaysincludedeals that corresponds to the Prebid.js alwaysIncludeDeals flag.

If true, then PBS-core would generate seatbid.bid.ext.prebid.targeting.hb_*_BIDDER values for all bids with a dealid. This is independent of which other ext.prebid.targeting flags are present.

We would also update the pbsBidAdapter to set this flag to true when the corresponding PBJS flag is set.

bretg commented 2 years ago

approved in committee

bretg commented 2 years ago

Released with PBS-Java 1.89. Updated auction endpoint docs.

SyntaxNode commented 7 months ago

Implemented in PBS-Go v2.8.0.