Closed github-lucas-bon closed 1 year ago
Here's a proposal for how this could work at a protocol level:
ext.prebid.sdk.renderers: [
{
"name":"PrebidRenderer",
"version":"2.1.1"
},
{
"name":"SampleRenderer",
"version":"1.0.0"
}
]
.RendererName
and .RendererVersion
. These get passed back to the SDK in ORTB seatbid.bid.ext.prebid.meta.{renderingapiname,renderingapiversion}. (Our standard is all lowercase, no separators in ORTB extensions)Notes:
hb_
targeting values because this doesn't need to go to the ad server.Thank you for the proposal !
For the point 4/5, we no longer use targeting
object to passback the datas, we continue to use ext
but currently not in a meta
object in the current implementation of the adapter neither our AdServer.
We can do the modification in the corresponding object if you feel it mandatory tho, we will anyway change the naming for plugin_renderers
to comply with OpenRTB.
@github-maxime-liege - my understanding is that this proposal is still under discussion.
It's generally a good idea to give these things a little time. I'll bring it up in the next Prebid Server committee meeting, which is in a week.
@github-maxime-liege - my understanding is that this proposal is still under discussion.
It's generally a good idea to give these things a little time. I'll bring it up in the next Prebid Server committee meeting, which is in a week.
No worries, i can wait on this side, we have a default configuration, but we are flexible according to your decision
discussed in committee. @SyntaxNode offered to do a review of the proposal here.
Okay @SyntaxNode, let us know if you have what you need in order to review it. Thanks.
The proposal from @bretg looks good. I would like to add stronger symmetry between the request parameters and response meta. If we use $.ext.prebid.sdk.renderers
on the request please consider using RendererName
and RendererVersion
for response meta.
Ok, proposal updated. Thanks @SyntaxNode
Thank you for the update, will follow this proposal then !
Thanks, this pull request will be updated accordingly https://github.com/prebid/prebid-mobile-android/pull/648
The proposal from @bretg looks good. I would like to add stronger symmetry between the request parameters and response meta. If we use
$.ext.prebid.sdk.renderers
on the request please consider usingRendererName
andRendererVersion
for response meta.
@SyntaxNode could you clarify more what you expect us to change on the bid response?
The current state was
...
"ext": {
"prebid": {
"type": "video",
"targeting": {
"hb_pb": "0.10",
"hb_env": "mobile-app",
"hb_size_prebid": "300x250",
"hb_pb_prebid": "0.10",
"hb_bidder_prebid": "prebid",
"hb_size": "300x250",
"hb_bidder": "prebid",
"hb_env_prebid": "mobile-app"
},
"meta": {
"renderer_name": "SamplePluginRenderer",
"renderer_version": "1.0.0"
}
},
...
But are you suggesting something like this?
...
"ext": {
"prebid": {
"type": "video",
"targeting": {
"hb_pb": "0.10",
"hb_env": "mobile-app",
"hb_size_prebid": "300x250",
"hb_pb_prebid": "0.10",
"hb_bidder_prebid": "prebid",
"hb_size": "300x250",
"hb_bidder": "prebid",
"hb_env_prebid": "mobile-app"
},
"meta": {
"renderer": {
"name": "SamplePluginRenderer",
"version": "2.1.1"
}
}
},
...
Let me know, thanks!
Right - @github-lucas-bon - you don't care about how it's represented in the Go code. In the ORTB, our standard is lower case with no separators:
...
"ext": {
"prebid": {
"type": "video",
"targeting": {
"hb_pb": "0.10",
"hb_env": "mobile-app",
"hb_size_prebid": "300x250",
"hb_pb_prebid": "0.10",
"hb_bidder_prebid": "prebid",
"hb_size": "300x250",
"hb_bidder": "prebid",
"hb_env_prebid": "mobile-app"
},
"meta": {
"rendererName": "SamplePluginRenderer",
"rendererVersion": "1.0.0"
}
},
...
@github-lucas-bon - note - changed the case of the meta fields after discussion in committee
Here's the summary of the PBS work:
.RendererName
, .RendererVersion
Flipping to ready-for-dev.
Hello @bretg as the pull request is now updated with the output we had here, our stored response prebid-stored-request-custom-rendering-test
should be updated accordingly to comply with the new fields below.
Is here the right place to request it?
*.bid.seatbid.ext.prebid.
"meta":{
"renderername":"SampleCustomRenderer",
"rendererversion":"1.0"
}
@github-lucas-bon - where is your stored response? Is that in Prebid's test PBS? I guess wherever it is, you would the body of the stored response to something like
[
{
"bid": [
{
"ext": {
"prebid": {
"meta": {
"rendererName":"SampleCustomRenderer",
"rendererVersion":"1.0"
}
}
},
"h": 50,
"w": 320,
"id": "f227a07f-1579-4465-bc5e-5c5b02a0c180",
"adm": "<img src=\"https://files.prebid.org/creatives/prebid320x50.png\">",
"ext":
{
"prebid":
{
"type": "banner"
}
},
"crid": "11111",
"impid": "a",
"price": 1
}
],
"seat": "rubicon",
"group": 0
}
]
Please use rendererName
and rendererVersion
casing, this matches the naming pattern used by the meta object.
fixed
Okay, keys from meta were updated in the pull request to camel case. Regarding where is the stored response I'm checking with Yuri since he help me with that.
Hi @bretg ! In the draft implementation of this feature, we used the stored request
to add the targeting keyword to (any) response.
...
"ext": {
"prebid": {
"adservertargeting": [
{
"key": "plugin_renderer_key",
"source": "static",
"value": "SampleCustomRenderer"
}
]
}
}
...
Now we should add the meta
object to the responses.
Can we utilize the stored request for this purpose as well, or should we add the meta
directly into each stored response that we need for tests?
@YuriyVelichkoPI - you can add the meta
fields to the stored responses.
@bretg @SyntaxNode Can you answer on what is the final input and what is the output ?
Thanks !
Input:
ext.prebid.sdk.renderers: [
{
"name":"PrebidRenderer",
"version":"2.1.1",
"data": { ... object ... }
},
{
"name":"SampleRenderer",
"version":"1.0.0"
}
]
Output:
{
"seatbid": [{
"bid": [{
...
"ext": {
"prebid": {
"meta": {
"rendererName": "SamplePluginRenderer",
"rendererVersion": "1.0.0",
"rendererData": { ... }
}
}
}]
}]
}
fair warning that the PBS teams are backed up right now with privacy efforts, so it may take a while for the central teams to get to this. community input would be welcomed.
Implemented in PBS-Go 0.267.0.
Hey everyone,
I noticed that you remove the field token
, is this an unwanted feature ?
Because we may see a utility in our case for this field, it could also be useful for other providers
Thanks a lot again for you support !
@github-maxime-liege - that word didn't appear in this issue until you mentioned it. But I looked over in the android repo issue and see it there. Is it a request field only? i.e. does token exist in the response?
It could be existing on the response yes
@github-maxime-liege - what is a token? Are there any concerns about where this value gets sent?
it is a simple string value that could be filled by the custom renderer with any data that it wants, we could rename it to data
or something, the initial proposal was token
@github-maxime-liege Thank you for the explanation. I like your suggestion to rename to data
, as the token
name can imply a security or authorization context which doesn't make much sense here.
I've edited the most recent comment from to @bretg to rename token to data.
Effects of this change:
fair warning that the PBS teams are backed up right now with privacy efforts, so it may take a while for the central teams to get to this. community input would be welcomed.
Thank you for your answer @SyntaxNode, i'll try to get into this to do the corresponding change.
Thanks again
Looks like i don't have rights to push a new branch on this repository
Looks like i don't have rights to push a new branch on this repository
You're contribution would certainly be welcomed. Most of us fork this repository, create a branch on our fork, and open a pull request from there. Please message me on Prebid Slack if you prefer otherwise.
Everything is done here, thanks everybody
Not done on PBS-Java. #8 on Magnite's list.
resolved with PBS-Java 2.2
Hello,
I am part of a task force to implement a new feature on prebid mobile that we call Custom Plugin Renderers, as you can see here. So it requires us to send new fields in the bid request. Implementation/documentation for the prebid adapter is ongoing as well.
So this issue is to ask your validation regarding this change in the bid request json we are submitting in the prebid android sdk repo: https://github.com/prebid/prebid-mobile-android/pull/648
We have these alternatives so far. Can we follow with any of them? Let me know WDYT, please.
*.ext.prebid.data.plugin_renderers
*.ext.data.plugin_renderers
*.ext.plugin_renderers