Bizzclick: rename bizzclick to blasto

BizzClick commented 1 month ago

Bizzclick has a big update, we are officially changing our name to blasto.

Related PR to prebid.github.io

github-actions[bot] commented 1 month ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 4912ca13699e31789fcf197b8dee9e682f2c82bf

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:    Builder             100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:    getHeaders          100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:    MakeRequests            83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:    getImpressionExt        85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:   buildEndpointURL        100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:   checkResponseStatusCodes    100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:   MakeBids            100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:   getMediaTypeForImp      100.0%
total:                                  (statements)            96.2%

github-actions[bot] commented 1 month ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, eb01327a789827d68558e3b7e7d70bd930254ce7

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:    Builder             100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:    getHeaders          100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:    MakeRequests            83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:    getImpressionExt        85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:   buildEndpointURL        100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:   checkResponseStatusCodes    100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:   MakeBids            100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:   getMediaTypeForImp      100.0%
total:                                  (statements)            96.2%

onkarvhanumante commented 1 month ago

@BizzClick

Consider adding blasto in DisabledBidderWarningMessages map.

https://github.com/prebid/prebid-server/blob/ec729e6e5d50a1306d76332fda52108b9d313c1d/exchange/adapter_util.go#L106-L123

github-actions[bot] commented 1 month ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, c505b26dfd82dfb5b935186aad66e13434ee7a73

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:    Builder             100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:    getHeaders          100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:    MakeRequests            83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:    getImpressionExt        85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:   buildEndpointURL        100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:   checkResponseStatusCodes    100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:   MakeBids            100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:   getMediaTypeForImp      100.0%
total:                                  (statements)            96.2%

github-actions[bot] commented 1 month ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, bd269e5136713918ca84913dc786b142dbbb3866

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:    Builder             100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:    getHeaders          100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:    MakeRequests            83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:    getImpressionExt        85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:   buildEndpointURL        100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:   checkResponseStatusCodes    100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:   MakeBids            100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:   getMediaTypeForImp      100.0%
total:                                  (statements)            96.2%

github-actions[bot] commented 2 weeks ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, c0af83d71a68f4e543861152df450030adbff24a

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:    Builder             100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:    getHeaders          100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:    MakeRequests            83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:    getImpressionExt        85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:   buildEndpointURL        100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:120:   checkResponseStatusCodes    100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:142:   MakeBids            100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:188:   getMediaTypeForImp      100.0%
total:                                  (statements)            96.2%

SyntaxNode commented 1 week ago

@BizzClick There was a comment on a similar PR recently where @bretg strongly felt the bizzclick name should rename active for a transition period unless there is literally zero current traffic. Is this the case for you? Does bizzclick currently receive no traffic?

bretg commented 1 week ago

https://docs.prebid.org/faq/prebid-server-faq.html#how-can-we-rename-our-bid-adapter

BizzClick commented 1 week ago

@SyntaxNode @bretg yes, bizzclick now has no traffic from pbs. Should i use aliasOf: "blasto" in existing bizzclick adapter? I would prefer to rename the existing adapter with mentioning that it used to be bizzclick.

bretg commented 1 week ago

Should i use aliasOf: "blasto" in existing bizzclick adapter?

@BizzClick - yes, that is the guideline. Adding an alias differs in PBS-Go and PBS-Java. See

I would prefer to rename the existing adapter with mentioning that it used to be bizzclick.

If you are 110% sure that not a single Prebid Server host company is using your adapter, then ok. But if anyone is using bizzclick, changing the name is going to break them when they upgrade and then people are going to get mad at Prebid for you changing your name. There are probably at least 50 companies using Prebid Server... how can you be sure that no one has enabled your adapter?

BizzClick commented 1 week ago

@bretg i'm 110% sure about that and it was considered before renaming. In any case someone from PBS community can contact our business team via email to confirm this.

bretg commented 1 week ago

i'm 110% sure about that

Very well.

bsardo commented 3 days ago

LGTM except for the YAML file update with respect to regional endpoints. We would also need to see another docs PR opened to capture the regional endpoint details.

github-actions[bot] commented 9 hours ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 10ab052fee4968366a05d2eca386714d6b042591

blasto

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:21:    Builder             100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:33:    getHeaders          100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:56:    MakeRequests            83.3%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:90:    getImpressionExt        85.7%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:107:   buildEndpointURL        100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:113:   checkResponseStatusCodes    100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:135:   MakeBids            100.0%
github.com/prebid/prebid-server/v2/adapters/blasto/blasto.go:181:   getMediaTypeForImp      100.0%
total:                                  (statements)            95.9%

BizzClick commented 9 hours ago

@bsardo sure, here's related PR https://github.com/prebid/prebid.github.io/pull/5466

prebid / prebid-server