New Adapter: QT - Githubissues

prebid / prebid-server

Open-source solution for running real-time advertising auctions in the cloud.

https://prebid.org/product-suite/prebid-server/

Apache License 2.0

404 stars 700 forks source link

New Adapter: QT #3696

Open qt-io opened 1 month ago

qt-io commented 1 month ago

DOC - https://github.com/prebid/prebid.github.io/pull/5331

github-actions[bot] commented 1 month ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 05e07f0b376e4fcee9d9e94a4e8238bada764361

qt

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/qt/qt.go:29:    Builder     100.0%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:36:    MakeRequests    76.5%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:91:    makeRequest 85.7%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:109:   MakeBids    100.0%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:146:   getBidType  83.3%
total:                              (statements)    85.3%

github-actions[bot] commented 1 month ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 8fafb879a2cfdded3aee681b7fed5a1ff5fead9c

qt

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/qt/qt.go:29:    Builder     100.0%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:36:    MakeRequests    76.5%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:91:    makeRequest 85.7%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:109:   MakeBids    100.0%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:146:   getBidType  100.0%
total:                              (statements)    86.6%

qt-io commented 4 weeks ago

@onkarvhanumante can you please check again?

qt-io commented 4 days ago

@SyntaxNode @gargcreation1992 @onkarvhanumante So let's sum this up. What do we need to do for this pull request to be approved?

We need to change maintainer email
What do we need to do with the code? Because every reviewer says differently. Do we need to change something or everything is ok?

github-actions[bot] commented 4 days ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 70882e96702bdc56d5995ea2d15f395fd74e20a3

qt

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/qt/qt.go:29:    Builder     100.0%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:36:    MakeRequests    76.5%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:91:    makeRequest 85.7%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:109:   MakeBids    100.0%
github.com/prebid/prebid-server/v2/adapters/qt/qt.go:146:   getBidType  100.0%
total:                              (statements)    86.6%

SyntaxNode commented 4 days ago

We need to change maintainer email

Yes. This needs to be a group email address and we need to receive a reply from a test email to approve.

What do we need to do with the code? Because every reviewer says differently. Do we need to change something or everything is ok?

I see only the len(adapterRequests) == 0 thread unresolved. The code is fine. Please review my comment to verify you want to include the "found no valid impressions" error message.

qt-io commented 8 hours ago

@SyntaxNode email changed