Closed saar120 closed 3 months ago
@saar120 consider adding json tests for following scenarios:
Note:
Coverage summary encompasses all commits leading up to the latest one, 7d64a63e3de045041ebae02f39744064461c90f8
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:22: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:29: MakeRequests 77.8%
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:67: getMediaTypeForBid 66.7%
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:83: MakeBids 94.4%
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:123: extractCid 71.4%
total: (statements) 82.4%
@saar120 consider adding json tests for following scenarios:
- request with multiple imps
- multi-format imp request
Added test for multiple imps Multi-format is not supported at the moment
@saar120 requesting to raise docs PR. Refer https://github.com/prebid/prebid.github.io/pull/5331 as example
@saar120 requesting to raise docs PR. Refer prebid/prebid.github.io#5331 as example
@onkarvhanumante Added to prebid docs (PR) Please let me know if anything else is needed
@onkarvhanumante can you please review again?
@onkarvhanumante @SyntaxNode Hey, Is there something else needs to be done for this to be merged? Can you please help?
@gargcreation1992 @Sonali-More-Xandr @onkarvhanumante @SyntaxNode can someone please assist in completing the review?
@Enigo @bsardo
@gargcreation1992 @Sonali-More-Xandr @onkarvhanumante @SyntaxNode @Enigo @bsardo
@Vungle-GordonTian @dmitris please assist
@gargcreation1992 please assist
@saar120 thank you for keeping patience with PR review. Added few comments. Requesting to provide feedback on them
Note:
Coverage summary encompasses all commits leading up to the latest one, 0bd805b7ea626d9c0a2e519bc8c43bad775b1dfa
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:22: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:29: MakeRequests 77.8%
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:67: getMediaTypeForBid 100.0%
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:79: MakeBids 89.5%
github.com/prebid/prebid-server/v2/adapters/vidazoo/vidazoo.go:122: extractCid 71.4%
total: (statements) 84.0%
@saar120 thank you for keeping patience with PR review. Added few comments. Requesting to provide feedback on them
I've updated it as suggested.
Code coverage summary
Note:
Coverage summary encompasses all commits leading up to the latest one, ad2b2ce87e46bc12222918efb1f4ad824dd8b509
vidazoo
Refer here for heat map coverage report