New Adapter : MediaGo

[SylviaF]

New Adapter : MediaGo https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/mediago.md

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, 34517f73f59fd9084aa76ab29da9210c8162bc50

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:27:  Builder         100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:38:  MakeRequests        100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:51:  makeRequest     86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getImpMediaGoExt    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:98:  getRegionInfo       80.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:111: getEndPoint     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:119: preProcess      100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: MakeBids        83.3%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:175: getBidType      69.6%
  total:                                  (statements)        85.9%
  

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, 409161ef1524757b07b4c8dc951f6ceb217f4d0e

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:27:  Builder         100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:38:  MakeRequests        100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:51:  makeRequest     86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getImpMediaGoExt    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:98:  getRegionInfo       80.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:111: getEndPoint     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:119: preProcess      100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: MakeBids        83.3%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:175: getBidType      60.7%
  total:                                  (statements)        82.5%
  

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, 3a8f603e6e674f04e5a390bbfe94fafccfc5621c

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:27:  Builder         100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:38:  MakeRequests        100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:51:  makeRequest     86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getImpMediaGoExt    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:98:  getRegionInfo       80.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:111: getEndPoint     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:119: preProcess      100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: MakeBids        83.3%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:175: getBidType      60.7%
  total:                                  (statements)        82.5%
  

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, 930ecf83ddb62ee4ebfb488c3e5d21f7383a3b43

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:28:  Builder     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:39:  MakeRequests    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:52:  makeRequest 86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getMediaGoExt   90.5%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:120: getRegionInfo   100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: getEndPoint 100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:141: preProcess  100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:155: MakeBids    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:188: getBidType  100.0%
  total:                                  (statements)    95.5%
  

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, 5e555e553d9441053b6209904799048679c11856

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:28:  Builder     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:39:  MakeRequests    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:52:  makeRequest 86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getMediaGoExt   95.2%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:120: getRegionInfo   100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: getEndPoint 100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:141: preProcess  100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:155: MakeBids    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:188: getBidType  100.0%
  total:                                  (statements)    96.6%
  

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, 687cbbea381892ea74504cf1ab6ca5017aee750c

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:28:  Builder     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:39:  MakeRequests    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:52:  makeRequest 86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getMediaGoExt   95.2%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:120: getRegionInfo   100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: getEndPoint 100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:141: preProcess  100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:155: MakeBids    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:188: getBidType  100.0%
  total:                                  (statements)    96.6%
  

[SylviaF]

@onkarvhanumante @Sonali-More-Xandr I have updated the code according to all the above comments. Could you please help me review it? Thank you so much!

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, b682e0b53abd56d64c1a7d0ac87a70059545f632

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:28:  Builder     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:39:  MakeRequests    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:52:  makeRequest 86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getMediaGoExt   95.2%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:120: getRegionInfo   100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: getEndPoint 100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:141: preProcess  100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:155: MakeBids    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:188: getBidType  100.0%
  total:                                  (statements)    96.6%
  

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, d776f1bad669881454cb09d8dedf7f5c70d62138

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:28:  Builder     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:39:  MakeRequests    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:52:  makeRequest 86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getMediaGoExt   95.2%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:120: getRegionInfo   100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: getEndPoint 100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:141: preProcess  100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:155: MakeBids    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:188: getBidType  100.0%
  total:                                  (statements)    96.6%
  

[SylviaF]

@onkarvhanumante @Sonali-More-Xandr @ChrisHuie Sorry to bother you all, but could you please let me know who will be able to review my code next? My boss keeps asking me why the code hasn't been merged yet. Thank you so much if anyone give me some advice!!!

[ChrisHuie]

@onkarvhanumante @Sonali-More-Xandr @ChrisHuie Sorry to bother you all, but could you please let me know who will be able to review my code next? My boss keeps asking me why the code hasn't been merged yet. Thank you so much if anyone give me some advice!!!

Yeah. @SylviaF trying to move this along. Can you please respond to Onkar's above question though about the fallback with no case matches. Think he is waiting on a response there for the review

[SylviaF]

@onkarvhanumante @Sonali-More-Xandr @ChrisHuie Sorry to bother you all, but could you please let me know who will be able to review my code next? My boss keeps asking me why the code hasn't been merged yet. Thank you so much if anyone give me some advice!!!

Yeah. @SylviaF trying to move this along. Can you please respond to Onkar's above question though about the fallback with no case matches. Think he is waiting on a response there for the review

Hi @ChrisHuie , I have responded last week. But I found that even my colleage can't see my review. Very strange.

[JimmyLuoJW]

Hi @onkarvhanumante @ChrisHuie, I think we may have some misunderstanding here. My colleague @SylviaF has been replying to all your questions but failed to submit so you never see her replying. Apologies for this as we're not familiar with the UI, and it's now addressed on our side and you can see her previous replies. Appreciate your support here.

[BradT-MediaGo]

Hi @onkarvhanumante I work on the MediaGo team and wanted to check in to see what the status was for our review. Realize we had some miscommunication with the github UI but I think that's all been taken care of now. Is there any update on your end in regards to timing or do you need anything from us to proceed? Also, after your review, is the next step to get it reviewed by @Sonali-More-Xandr?

I see 'All Checks have passed' so hoping that's good news!

[SyntaxNode]

Looking at the docs PR, I see that the test and bidfloor parameters from PBJS are not included in the PBS adapter. Are the region parameter also available in PBJS?

@bretg for input on PBJS and PBS parameters.

[bretg]

Good catch @SyntaxNode - I've asked for the relevant changes in the docs PR https://github.com/prebid/prebid.github.io/pull/5395

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, b74708dc20337f58226998a93bb255bb98bdf644

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:28:  Builder     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:39:  MakeRequests    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:52:  makeRequest 86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getMediaGoExt   95.2%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:120: getRegionInfo   100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: getEndPoint 100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:141: preProcess  100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:155: MakeBids    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:188: getBidType  100.0%
  total:                                  (statements)    96.6%
  

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

• Coverage summary encompasses all commits leading up to the latest one, d750484d3c05ac01a051acad5f2a63aaa4b582e1

  mediago

  Refer here for heat map coverage report

  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:28:  Builder     100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:39:  MakeRequests    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:52:  makeRequest 86.7%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:84:  getMediaGoExt   95.2%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:120: getRegionInfo   100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:133: getEndPoint 100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:141: preProcess  100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:155: MakeBids    100.0%
  github.com/prebid/prebid-server/v2/adapters/mediago/mediago.go:188: getBidType  100.0%
  total:                                  (statements)    96.6%
  

[SylviaF]

Looking at the docs PR, I see that the test and bidfloor parameters from PBJS are not included in the PBS adapter. Are the region parameter also available in PBJS?

@bretg for input on PBJS and PBS parameters.

@SyntaxNode @bretg Thank you for your suggestions. I have made all the corrections, including updating the parameter validity explanations in the GitHub.io documentation.