New Adapter: bigoad - Githubissues

github-actions[bot] commented 1 month ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, a40121d8723aa1b25016be486b63d0bea819ae9e

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:    Builder         100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:    MakeRequests        81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:    getHeaders      100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:    addNonEmptyHeaders  100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:    getImpExt       87.5%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:    buildEndpointURL    100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:   MakeBids        78.9%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:155:   getBidType      85.7%
total:                                  (statements)        86.2%

github-actions[bot] commented 1 month ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 74967e98b22e734afec1e901758d83627b61cd38

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:    Builder         100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:    MakeRequests        81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:    getHeaders      100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:    addNonEmptyHeaders  100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:    getImpExt       87.5%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:    buildEndpointURL    100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:   MakeBids        80.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:   getBidType      90.9%
total:                                  (statements)        87.3%

BIGOAds commented 3 weeks ago

Thanks. BigoAd had recieved this email.

-----原始邮件----- 发件人:"Onkar Hanumante" @.> 发送时间:2024-06-05 17:54:38 (星期三) 收件人: prebid/prebid-server @.> 抄送: BIGOAds @.>, Mention @.> 主题: [Newsletter] Re: [prebid/prebid-server] New Adapter: bigoad (PR #3711)

@onkarvhanumante commented on this pull request.

In static/bidder-info/bigoad.yaml:

@@ -0,0 +1,20 @@ +endpoint: "http://{{.Host}}/Ad/GetAdOut?sspid={{.SspId}}" +endpointCompression: gzip +geoscope:

USA

CHN

RUS +maintainer:

email: @.***

Prebid team has sent an email to verify above contact email address. Requesting to provide feedback on email thread

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

github-actions[bot] commented 2 weeks ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, fccd9b702a0c022d3c505c7d39fcb9f1361a7db3

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:    Builder         100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:    MakeRequests        81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:    getHeaders      100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:    addNonEmptyHeaders  100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:    getImpExt       100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:    buildEndpointURL    100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:   MakeBids        90.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:   getBidType      100.0%
total:                                  (statements)        93.0%

BIGOAds commented 2 weeks ago

I had fix the problem above, please review again, thanks.

BIGOAds commented 1 week ago

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

onkarvhanumante commented 3 days ago

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at https://github.com/prebid/prebid-server/pull/3711#discussion_r1627401329 comment to proceed with code review

SyntaxNode commented 2 days ago

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to BigoAds@bigo.sg on June 5th to verify and have not received a reply. Did you get our email from prebid@microsoft.com?

BIGOAds commented 5 hours ago

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to BigoAds@bigo.sg on June 5th to verify and have not received a reply. Did you get our email from prebid@microsoft.com?

github-actions[bot] commented 4 hours ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 2baaaa3d9377d743cf368353bfa3dd8855723881

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:    Builder         100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:    MakeRequests        81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:    getHeaders      100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:    addNonEmptyHeaders  100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:    getImpExt       100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:    buildEndpointURL    100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:   MakeBids        90.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:   getBidType      100.0%
total:                                  (statements)        93.0%

onkarvhanumante commented 2 hours ago

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to BigoAds@bigo.sg on June 5th to verify and have not received a reply. Did you get our email from prebid@microsoft.com?

@BIGOAds could you resend response. Prebid team did not received any response

onkarvhanumante commented 2 hours ago

@BIGOAds ptal at conflicts in following files

exchange/adapter_builders.go
openrtb_ext/bidders.go

prebid / prebid-server

New Adapter: bigoad #3711

Code coverage summary

bigoad

Code coverage summary

bigoad

Code coverage summary

bigoad

Code coverage summary

bigoad