search

prebid / prebid-server

Open-source solution for running real-time advertising auctions in the cloud.
https://prebid.org/product-suite/prebid-server/
Apache License 2.0
403 stars 698 forks source link

Nobid: Add iframe sync support #3732

Closed redaguermas closed 1 day ago

redaguermas commented 3 weeks ago

Added support for iframe user sync.

redaguermas commented 3 weeks ago

Can you please take a look at this PR? The validation failed for a module that is not ours.

redaguermas commented 3 weeks ago

Hello @bsardo , What should I do to get this PR going?

redaguermas commented 2 weeks ago

Can you please review this PR?

redaguermas commented 2 weeks ago

@bsardo Can you please review this PR?

redaguermas commented 2 weeks ago

Can someone please review this PR?

redaguermas commented 1 week ago

Can some one please review this PR?

bsardo commented 4 days ago

Hi @redaguermas, sorry for the slow response. I and a lot of the team have been out of the office recently on vacation. We'll make this a priority this week.

SyntaxNode commented 3 days ago

Confirmed the new iframe user sync endpoint works. However, please be advised the user id in my test is 729 characters long. We expect the id to be a much smaller (uuid length) opaque identifier. Based on the length, it looks like this uid may be encoding data.

You run the risk of hosts disabling your cookie sync since it uses a lot of valuable cookie storage space. Consider changing to a smaller id. Approving, since the url is working.

redaguermas commented 2 days ago

Thank you @SyntaxNode . We are going to look into creating a shorter ID but it will take some time because of technical changes that need to take place in the backend. Can you please merge this PR and we will address the ID length in another ticket/PR. -Regards

SyntaxNode commented 2 days ago

We are going to look into creating a shorter ID but it will take some time because of technical changes that need to take place in the backend. Can you please merge this PR and we will address the ID length in another ticket/PR.

Much appreciated. Thank you.

I mentioned this wasn't a blocker and already approved the PR. It's waiting for a second reviewer to approve and then you're good.