Open lm-ved opened 3 months ago
Note:
Coverage summary encompasses all commits leading up to the latest one, b583eb4e9663f4ea9d9a0d2b278df6ce066de136
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:23: Builder 80.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:35: MakeRequests 87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:74: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:110: buildEndpointURL 100.0%
total: (statements) 92.7%
Note:
Coverage summary encompasses all commits leading up to the latest one, 84b70186c04d8caac2aafeaac324f76afb828663
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:55: Builder 87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:73: MakeRequests 87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:112: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:148: buildEndpointURL 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:155: parseExtraInfo 92.3%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:181: defaultHost 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:185: assignDoohHost 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:196: resolveHost 83.3%
total: (statements) 92.9%
Note:
Coverage summary encompasses all commits leading up to the latest one, a26ae595ae3b0ea2348f378e3ced64b1357d7cb6
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:55: Builder 87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:73: MakeRequests 87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:112: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:148: buildEndpointURL 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:155: parseExtraInfo 92.3%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:181: defaultHost 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:185: assignDoohHost 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:196: resolveHost 83.3%
total: (statements) 92.9%
Hi @SyntaxNode / @bretg / @bsardo , Are there any other changes required before this can be approved/merged?
Note:
Coverage summary encompasses all commits leading up to the latest one, 2e1cb183c1d5ae982cfc664ccc2b2198d2c57a2d
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:55: Builder 87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:73: MakeRequests 87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:112: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:148: buildEndpointURL 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:155: parseExtraInfo 92.3%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:181: defaultHost 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:185: assignDoohHost 100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:196: resolveHost 83.3%
total: (statements) 92.9%
Hi @SyntaxNode / @bretg / @bsardo , We've also added commit: https://github.com/prebid/prebid-server/pull/3750/commits/2e1cb183c1d5ae982cfc664ccc2b2198d2c57a2d to support usersync. Let us know please if there are any further steps for this to be approved/merged.
@lm-ved, I will give this a look shortly.
@bsardo Could you please review this? It is a very important and business-impacting change for us. Let us know if there are any outstanding action items for approval.
Thank you.
Hi @bsardo / @SyntaxNode / @bretg, I've created another PR that has fewer changes to help expedite the review process: https://github.com/prebid/prebid-server/pull/3862 . Please review it instead of this one for the time being. Moving this one to draft until the linked PR is merged.
@lm-ved your other PR has been merged. Let me know when this is ready for review again.
📋 Checklist