Open Net-burst opened 2 weeks ago
Why introduce another config option and not simply fix it?
i.e.:
if imp[].MEDIA_TYPE
is null
skip this MEDIA_TYPE
and don't inject battr
;
Discussed in committee. @bretg do you recall why this module was designed this way? The general opinion here is that this a bug but there is some concern as to whether we should consider this a breaking change such that backwards compatibility should be considered.
Updated the issue description to reflect that this is indeed a bug.
There seems to be a design flaw with the blocking module. It was there from the moment the blocking module was initially released, but it became apparent only after we added
video
andaudio
support.The issue lies in the fact that the blocking module doesn't care whether there is a media type object present for the purposes of adding
battr
. If an account has a configuration for banner/video/audio battr, the module will populateimp[].banner/video/audio.battr
even ifimp[].banner/video/audio
doesn't exist. This would result in the impression potentially having multiple (basically bogus) media types.OpenRTB blocking module should inject
battr
only if the media type object (imp[].banner/video/audio
) exists. If the object isnull
, the module shouldn’t create an empty one to house thebattr
.