New Adapter: Loopme - Githubissues

prebid / prebid-server

Open-source solution for running real-time advertising auctions in the cloud.

https://prebid.org/product-suite/prebid-server/

Apache License 2.0

434 stars 744 forks source link

New Adapter: Loopme #4023

Open ambalashov opened 3 weeks ago

github-actions[bot] commented 3 weeks ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 7d984d94bee2686aeccf7cd031e33b9ce725c811

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:20:    MakeRequests    88.9%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:54:    MakeBids    100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:92:    parseBidderExt  100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:105:   getBidType  100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:123:   Builder     75.0%
total:                                  (statements)    94.5%

github-actions[bot] commented 3 weeks ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, a239d7322127612580e7dde892727135b4fe03d2

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:20:    MakeRequests    88.9%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:54:    MakeBids    100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:92:    parseBidderExt  100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:105:   getBidType  100.0%
github.com/prebid/prebid-server/v2/adapters/loopme/loopme.go:123:   Builder     75.0%
total:                                  (statements)    94.5%

bsardo commented 3 weeks ago

Hi @ambalashov, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

github-actions[bot] commented 2 weeks ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, e74eb4e9161b74bf6516a394ab7e6f08a17ad0ff

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:20:    MakeRequests    88.9%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:54:    MakeBids    100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:92:    parseBidderExt  100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:105:   getBidType  100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:123:   Builder     75.0%
total:                                  (statements)    94.5%

bsardo commented 1 week ago

@PyjamaWarrior can you please review?

MaksymTeqBlaze commented 5 days ago

I have sent a verification email. Please respond

verified

github-actions[bot] commented 5 days ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 0ad799a1899005caa01d5e85ee8fe463b94d03a7

loopme

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:19:    MakeRequests    85.7%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:48:    MakeBids    100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:97:    getBidType  100.0%
github.com/prebid/prebid-server/v3/adapters/loopme/loopme.go:115:   Builder     100.0%
total:                                  (statements)    95.9%

Chandrahaas commented 3 days ago

I have sent a verification email. Please respond

We sent a response on Nov 21, 9:59 AM . Thanks.