Equativ: Update bid type computation with Markup type

prebid / prebid-server

Open-source solution for running real-time advertising auctions in the cloud.

https://prebid.org/product-suite/prebid-server/

Apache License 2.0

434 stars 743 forks source link

Equativ: Update bid type computation with Markup type #4045

Open rneuplanche opened 2 weeks ago

rneuplanche commented 2 weeks ago

In order to support correctly multi impression type bid request, we need to change the way we compute the BidType in the Equativ adapter

github-actions[bot] commented 2 weeks ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, f743645fb98d73e0a1b29b7f3f9286f514d03cd2

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:  Builder             100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:  MakeRequests            85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123: MakeBids            100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161: BuildEndpointURL        83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175: getBidTypeFromMarkupType    83.3%
total:                                      (statements)            88.6%

github-actions[bot] commented 2 weeks ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 437b9e147a3e49af1deb5bdeb9c7faf9ed716bf8

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:  Builder             100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:  MakeRequests            85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123: MakeBids            100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161: BuildEndpointURL        83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175: getBidTypeFromMarkupType    83.3%
total:                                      (statements)            88.6%

github-actions[bot] commented 2 weeks ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, 6b13b58230d16eb0d6bc2cae78dfccbc7fac9b0f

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:  Builder             100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:  MakeRequests            85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123: MakeBids            100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161: BuildEndpointURL        83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175: getBidTypeFromMarkupType    83.3%
total:                                      (statements)            88.6%

github-actions[bot] commented 1 week ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, d288bec2f6c4e71d9a2f4164c78db53789ed643a

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:  Builder             100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:  MakeRequests            85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123: MakeBids            100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161: BuildEndpointURL        83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175: getBidTypeFromMarkupType    83.3%
total:                                      (statements)            88.6%

rneuplanche commented 1 week ago

Looks good. Does this take care of prebid server v2 and v3? @mdaddario-STR

Not sure if the Prebid team is still publishing updates on PBS V2 🤔

github-actions[bot] commented 1 week ago

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

Coverage summary encompasses all commits leading up to the latest one, ccd5dd475615c28332c07759c2dfaa3804332649

smartadserver

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:25:  Builder             100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:33:  MakeRequests            85.4%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:123: MakeBids            100.0%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:161: BuildEndpointURL        83.3%
github.com/prebid/prebid-server/v3/adapters/smartadserver/smartadserver.go:175: getBidTypeFromMarkupType    83.3%
total:                                      (statements)            88.6%

mdaddario-STR commented 1 week ago

👍

rneuplanche commented 2 days ago

Hello @przemkaczmarek could we have a review on this ? I don't know the process on your end ? Thanks in advance 🙏