prebid / prebid-server

Open-source solution for running real-time advertising auctions in the cloud.
https://prebid.org/product-suite/prebid-server/
Apache License 2.0
434 stars 743 forks source link

jsonpatch is really slow and we shouldn't need to merge if there is no default. #4071

Open scr-oath opened 20 hours ago

SyntaxNode commented 9 hours ago

Yes, it is. We've experimented and had success with jsonutil.Merge as an alternate to jsonpatch for First Party Data. jsonutil.Merge is built on jsoniter taking advantage of that library's callback architecture to customize behavior of ext handling.

It's our intention to replace jsonpatch usage with jsonutil.Merge for a performance increase. Anyone is welcome to put up a PR that beats us to it. :)

No argument against skipping steps which don't apply to everyone. in this case though, how can the default account json ever be nil?