prebid / prebid-universal-creative

Apache License 2.0
43 stars 71 forks source link

Use MessageChannel for cross-frame messages #154

Closed dgirardi closed 2 years ago

dgirardi commented 2 years ago

Use MessageChannels to enable communication from behind an opaque origin

See https://github.com/prebid/Prebid.js/issues/7870 Related PBJS changes: https://github.com/prebid/Prebid.js/pull/7953

NOTE that I have been unable to test integration with Prebid for native ads (non-native case works as expected). I'll continue to try to figure that out, but also posting this in the hope that someone here might have an easier time with that.

dgirardi commented 2 years ago

Tested native integration (native-tracker.js) using this test page: https://gist.github.com/dgirardi/7525bc3d9f7b92f3ff919fc10ede81d6

native-trk.js tested with this https://gist.github.com/8f45593ced964f0cdd23c2615af4bdc2 (creative set up according to https://docs.prebid.org/adops/setting-up-prebid-native-in-dfp.html)

Both expect PUC to live at localhost:9990

patmmccann commented 2 years ago

@msm0504 are you able to take a look? you reviewed the paired changes on prebid js

robertrmartinez commented 1 year ago

Mark no longer should be on rotation!

I’ll take a look at this today!

On Fri, Apr 22, 2022 at 8:12 AM Patrick McCann @.***> wrote:

@msm0504 https://github.com/msm0504 are you able to take a look?

— Reply to this email directly, view it on GitHub https://github.com/prebid/prebid-universal-creative/pull/154#issuecomment-1106611639, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKTKOT2HJUWSTMYIYWJFOLVGK6ULANCNFSM5MQWCSEQ . You are receiving this because you were assigned.Message ID: @.***>