Separate scripts for different creative types

prebid / prebid-universal-creative

Apache License 2.0

43 stars 71 forks source link

Separate scripts for different creative types #165

Closed musikele closed 1 year ago

musikele commented 2 years ago

With this PR when puc is built (gulp build) output of that task will be multiple .js file. Each .js file is responsible for rendering ad of specific format:

amp.js
banner.js
mobile.js
native.js
video.js

Before, when puc was built, in the output we would have:

creative.js (for all formats except native)
native-render.js (only for native format)

Not a single function was changed, all functions were just moved around (some to different files).
Also, some OOP concepts were removed to make treeshaking easier.

musikele commented 2 years ago

Docs PR: https://github.com/prebid/prebid.github.io/pull/3645

jsnellbaker commented 2 years ago

@musikele When you get a chance, can you review/resolve the conflicts in this PR? Thanks.

robertrmartinez commented 1 year ago

Hi when I pull down this and try npm ci I get the following error:

I think maybe we should commit the changes to package-lock.json as well?

musikele commented 1 year ago

@robertrmartinez Added package-lock.json to fix npm ci.

patmmccann commented 1 year ago

@musikele looks like we're ready to merge once conflicts are resolved?

musikele commented 1 year ago

@patmmccann rebased

GLStephen commented 1 year ago

@patmmccann came by to check up on things after our discussion today, is the README referencing https://cdn.jsdelivr.net/npm/prebid-universal-creative@latest/dist/%%PATTERN:hb_format%%.js out of sync with actual jsdeliver deployment right now? https://cdn.jsdelivr.net/npm/prebid-universal-creative@latest/dist/banner.js is not available. Looks like there is just some flux in state of things, but wanted to bring it up if it mattered.