prebid / prebid-universal-creative

Apache License 2.0
43 stars 69 forks source link

Improve creative resizing logic #191

Open dgirardi opened 1 year ago

dgirardi commented 1 year ago

When using native-render.js, after the ad is rendered, we take the ad height and send it to Prebid for it to be set on the frame's container:

https://github.com/prebid/prebid-universal-creative/blob/0d0ef0466cda24a6db14f18255da7c2d77b5c22e/src/nativeAssetManager.js#L381

This is because GPT will fix the safeframe's height based on the contents it knows about, and it does not know that we are dynamically generating it. However, this approach has problems (see https://github.com/prebid/prebid-universal-creative/pull/190#issuecomment-1308640825):

patmmccann commented 7 months ago

allowPushExpansion support still needed